Removed unused model reference in member API router controller

[EvanHahn]

no ref

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Pro Plus

Run ID: 3994459a-fc5a-4c34-b257-d1bce2f7d6c4

📥 Commits

Reviewing files that changed from the base of the PR and between 21e5c1e and 1c257ac.

📒 Files selected for processing (2)

• ghost/core/core/server/services/members/members-api/controllers/router-controller.js
• ghost/core/core/server/services/members/members-api/members-api.js

💤 Files with no reviewable changes (2)

• ghost/core/core/server/services/members/members-api/controllers/router-controller.js
• ghost/core/core/server/services/members/members-api/members-api.js

Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review.

📜 Recent review details

⏰ Context from checks skipped due to timeout. (3)

• GitHub Check: Setup
• GitHub Check: Detect Tinybird changes
• GitHub Check: Analyze (javascript-typescript)

---

Walkthrough

The members API no longer passes StripePrice when it constructs RouterController. The constructor contract also removes the corresponding parameter, documentation entry, and stored property.

Merge Risk: ⚪ Minimal · up to 1c257

This localized cleanup removes unused references without identified behavior or production impact, so no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description says "no ref" and does not provide meaningful information about the changeset.	Update the description to state that the unused StripePrice model reference was removed from the member API router controller.

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: removal of an unused model reference from the member API router controller.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Type-Safe Boundaries	✅ Passed	The PR only removes the unused StripePrice dependency from RouterController and its members-api.js wiring. The parent diff shows no added code, boundary-data consumption, any, unchecked as, …
New Files Are Typescript	✅ Passed	The check passes. The pull request changes only two pre-existing files: router-controller.js and members-api.js. Git reports both paths as modified (M), with no added files. The JavaScript chang…

Full details: Type-Safe Boundaries

Explanation

The PR only removes the unused StripePrice dependency from RouterController and its members-api.js wiring. The parent diff shows no added code, boundary-data consumption, any, unchecked as, @ts-nocheck, @ts-ignore, or hand-written type. The current controller has no remaining StripePrice reference.

Full details: New Files Are Typescript

Explanation

The check passes. The pull request changes only two pre-existing files: router-controller.js and members-api.js. Git reports both paths as modified (M), with no added files. The JavaScript changes remove an existing dependency and do not add a new .js source file.

• Fix all pre-merge checks with AI

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch remove-unused-stripeprice

---

_{Comment @coderabbitai help to get the list of available commands.}

[nx-cloud]

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci

---

View your CI Pipeline Execution ↗ for commit 1c257ac

Command	Status	Duration	Result
nx run ghost:test:ci:integration	✅ Succeeded	4m 48s	View ↗
nx run ghost:test:legacy	✅ Succeeded	3m 12s	View ↗
nx run ghost-monorepo:lint:boundaries	✅ Succeeded	23s	View ↗
nx run-many -t test:unit -p ghost	✅ Succeeded	34s	View ↗
nx run-many -t lint -p ghost,ghost-monorepo	✅ Succeeded	21s	View ↗
nx run-many --target=build --projects=tag:publi...	✅ Succeeded	1s	View ↗
nx run @tryghost/admin:build	✅ Succeeded	5s	View ↗
nx run @tryghost/e2e:test:fixtures	✅ Succeeded	<1s	View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗

---

☁️ Nx Cloud last updated this comment at 2026-08-28 14:51:23 UTC

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.99%. Comparing base (21e5c1e) to head (1c257ac).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #30366      +/-   ##
==========================================
- Coverage   75.99%   75.99%   -0.01%     
==========================================
  Files        1676     1676              
  Lines      159975   159971       -4     
  Branches    19574    19570       -4     
==========================================
- Hits       121572   121568       -4     
- Misses      37382    37413      +31     
+ Partials     1021      990      -31     

Flag	Coverage Δ
e2e-tests	77.65% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.