Simplified staff invite signup form

[acburdine]

no ref

[nx-cloud]

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci

---

View your CI Pipeline Execution ↗ for commit ad0c019

Command	Status	Duration	Result
nx run ghost:test:ci:integration	✅ Succeeded	5m 18s	View ↗
nx run @tryghost/admin:test:acceptance	✅ Succeeded	9m 7s	View ↗
nx run-many -t test:unit -p @tryghost/admin,ghost	✅ Succeeded	4m 35s	View ↗
nx run ghost:test:legacy	✅ Succeeded	3m 14s	View ↗
nx run ghost-admin:test	✅ Succeeded	2m 44s	View ↗
nx run ghost-monorepo:lint:boundaries	✅ Succeeded	24s	View ↗
nx run-many -t lint -p ghost-monorepo,ghost-adm...	✅ Succeeded	1m 58s	View ↗
nx run @tryghost/admin:build	✅ Succeeded	1m 33s	View ↗
Additional runs (2)	✅ Succeeded	...	View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗

---

☁️ Nx Cloud last updated this comment at 2026-08-31 23:55:00 UTC

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Team

Run ID: e65ba01d-2031-46f2-b1c7-00d39c906e9a

📥 Commits

Reviewing files that changed from the base of the PR and between 85fc64e and ad0c019.

📒 Files selected for processing (10)

• .secretlintrc.json
• apps/ember-admin/app/controllers/signup.js
• apps/ember-admin/app/routes/signup.js
• apps/ember-admin/app/templates/signup.hbs
• apps/ember-admin/tests/acceptance/signup-test.js
• e2e/helpers/pages/admin/invite-signup-page.ts
• e2e/tests/admin/settings/staff-invites.test.ts
• ghost/core/core/server/api/endpoints/utils/validators/input/invitations.js
• ghost/core/core/server/services/invitations/accept.js
• ghost/core/test/legacy/api/admin/authentication.test.js

💤 Files with no reviewable changes (1)

• ghost/core/core/server/api/endpoints/utils/validators/input/invitations.js

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.

📜 Recent review details

⏰ Context from checks skipped due to timeout. (8)

• GitHub Check: Build Docker Images
• GitHub Check: Legacy tests (Node 22.23.1, mysql8)
• GitHub Check: App Playwright Acceptance Tests (@tryghost/admin)
• GitHub Check: Unit tests (Node 22.23.1)
• GitHub Check: Acceptance tests (Node 22.23.1, mysql8)
• GitHub Check: Lint
• GitHub Check: Build Admin
• GitHub Check: Admin tests - Chrome

🧰 Additional context used

📓 Path-based instructions (12)

Review new or changed service boundaries for explicit dependency ownership,

⚙️ CodeRabbit configuration file

Files:

• ghost/core/core/server/services/invitations/accept.js

Review whether tests prove changed behaviour, meaningful error/edge paths, and

⚙️ CodeRabbit configuration file

Files:

• ghost/core/test/legacy/api/admin/authentication.test.js
• e2e/tests/admin/settings/staff-invites.test.ts
• apps/ember-admin/tests/acceptance/signup-test.js

Review fixture/page-object lifecycle, concurrency, reset timing, reusable

⚙️ CodeRabbit configuration file

Files:

• e2e/helpers/pages/admin/invite-signup-page.ts

Review semantic E2E quality that static checks miss: test the user-visible

⚙️ CodeRabbit configuration file

Files:

• e2e/tests/admin/settings/staff-invites.test.ts

New source files must be TypeScript: flag new JS files as a required change

⚙️ CodeRabbit configuration file

Files:

• apps/ember-admin/app/routes/signup.js
• ghost/core/test/legacy/api/admin/authentication.test.js
• apps/ember-admin/app/controllers/signup.js
• ghost/core/core/server/services/invitations/accept.js
• apps/ember-admin/tests/acceptance/signup-test.js

Review lens: "where does this data become trusted?"

⚙️ CodeRabbit configuration file

Files:

• e2e/tests/admin/settings/staff-invites.test.ts
• e2e/helpers/pages/admin/invite-signup-page.ts

Prioritise concrete correctness, security, data-integrity, compatibility,

⚙️ CodeRabbit configuration file

Files:

• apps/ember-admin/app/routes/signup.js
• ghost/core/test/legacy/api/admin/authentication.test.js
• apps/ember-admin/app/controllers/signup.js
• e2e/tests/admin/settings/staff-invites.test.ts
• apps/ember-admin/app/templates/signup.hbs
• e2e/helpers/pages/admin/invite-signup-page.ts
• ghost/core/core/server/services/invitations/accept.js
• apps/ember-admin/tests/acceptance/signup-test.js

Boot owns service initialization; do not

📄 CodeRabbit inference engine (AGENTS.md)

Files:

• ghost/core/core/server/services/invitations/accept.js

Follow the locator priority in the E2E writing guide; do not copy generated

📄 CodeRabbit inference engine (e2e/AGENTS.md)

Files:

• e2e/tests/admin/settings/staff-invites.test.ts
• e2e/helpers/pages/admin/invite-signup-page.ts

Type-safe boundaries: Fail only if the PR:

📄 CodeRabbit inference engine (Custom checks)

Files:

• e2e/tests/admin/settings/staff-invites.test.ts
• e2e/helpers/pages/admin/invite-signup-page.ts

New files are TypeScript: Fail if the PR adds a new .js/.jsx/.cjs/.mjs source file, unless it is: a DB

📄 CodeRabbit inference engine (Custom checks)

Files:

• apps/ember-admin/app/routes/signup.js
• ghost/core/test/legacy/api/admin/authentication.test.js
• apps/ember-admin/app/controllers/signup.js
• ghost/core/core/server/services/invitations/accept.js
• apps/ember-admin/tests/acceptance/signup-test.js

Always use `pnpm`, never npm or Yarn.

📄 CodeRabbit inference engine (e2e/AGENTS.md)

Files:

• apps/ember-admin/app/routes/signup.js
• ghost/core/test/legacy/api/admin/authentication.test.js
• apps/ember-admin/app/controllers/signup.js
• e2e/tests/admin/settings/staff-invites.test.ts
• apps/ember-admin/app/templates/signup.hbs
• e2e/helpers/pages/admin/invite-signup-page.ts
• ghost/core/core/server/services/invitations/accept.js
• apps/ember-admin/tests/acceptance/signup-test.js

🔇 Additional comments (9)

ghost/core/core/server/services/invitations/accept.js (1)

33-35: LGTM!

Also applies to: 50-50

apps/ember-admin/tests/acceptance/signup-test.js (1)

24-24: LGTM!

Also applies to: 55-65

e2e/helpers/pages/admin/invite-signup-page.ts (1)

15-15: LGTM!

Also applies to: 20-22

e2e/tests/admin/settings/staff-invites.test.ts (1)

26-27: LGTM!

.secretlintrc.json (1)

52-53: LGTM!

ghost/core/test/legacy/api/admin/authentication.test.js (1)

383-405: LGTM!

apps/ember-admin/app/routes/signup.js (1)

55-55: LGTM!

apps/ember-admin/app/templates/signup.hbs (1)

42-43: LGTM!

apps/ember-admin/app/controllers/signup.js (1)

51-51: LGTM!

Also applies to: 100-100

---

Walkthrough

The invitation signup flow now populates the email from the invitation token and renders it as read-only and disabled. The frontend continues sending the email for older Core versions. Invitation acceptance uses the email stored on the invitation record for user lookup and creation. Validators no longer reject requests without an email. Acceptance and end-to-end tests now verify the pre-filled email behavior. The credential-assignment rule allows signupDetails.password.

Suggested reviewers: 9larsons

Merge Risk: ⚪ Minimal · up to ad0c0

This localized signup-form change has no actionable merge-blocking risk remaining after normal checks and review.

🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description, "no ref," is too vague to explain the changeset or its purpose.	Provide a brief description of the signup form changes, including the pre-filled disabled email field and the related invitation acceptance updates.

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: simplifying the staff invite signup form, including the pre-filled and disabled email field.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Type-Safe Boundaries	✅ Passed	No explicit type-safety failure is introduced. The changed TypeScript page-object code only updates a locator and method signature; it adds no any, unchecked as, or TypeScript suppression. The inv…
New Files Are Typescript	✅ Passed	The pull request adds no files. The commit diff contains only modifications, and the added-path checks return no results. Therefore, it does not add a new .js, .jsx, .cjs, or .mjs source file.

Full details: Type-Safe Boundaries

Explanation

No explicit type-safety failure is introduced. The changed TypeScript page-object code only updates a locator and method signature; it adds no any, unchecked as, or TypeScript suppression. The invitation POST still passes through the existing input validator before accept() consumes the request fields. The new invite.get('email') value comes from the existing Invite model and its database contract, which defines email as a non-null string with isEmail validation; the base model applies that schema validator on writes. Signup validation also checks the populated email before completion. No new duplicated Zod type or boundary bypass appears in the diff.

• Fix all pre-merge checks with AI

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch invite-simplified

---

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.06%. Comparing base (85fc64e) to head (ad0c019).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...st/core/core/server/services/invitations/accept.js	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #30404      +/-   ##
==========================================
- Coverage   76.09%   76.06%   -0.03%     
==========================================
  Files        1679     1679              
  Lines      160100   160153      +53     
  Branches    19611    19614       +3     
==========================================
- Hits       121833   121826       -7     
- Misses      37282    37304      +22     
- Partials      985     1023      +38     

Flag	Coverage Δ
admin-tests	57.47% <100.00%> (+0.09%)	⬆️
e2e-tests	77.72% <0.00%> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.