Fixed email validation during member stripe checkout - #30405
Conversation
no ref --------- Co-authored-by: Steve Larson <9larsons@gmail.com> Co-authored-by: Austin Burdine <austin@ghost.org>
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run ghost:test:ci:integration |
✅ Succeeded | 3m 31s | View ↗ |
nx run ghost:test:legacy |
✅ Succeeded | 3m 29s | View ↗ |
nx run ghost-monorepo:lint:boundaries |
✅ Succeeded | 16s | View ↗ |
nx run-many -t lint -p ghost,ghost-monorepo |
✅ Succeeded | 15s | View ↗ |
nx run-many -t test:unit -p ghost |
✅ Succeeded | 27s | View ↗ |
nx run @tryghost/admin:build |
✅ Succeeded | 4s | View ↗ |
nx run-many --target=build --projects=tag:publi... |
✅ Succeeded | <1s | View ↗ |
nx run @tryghost/e2e:test:fixtures |
✅ Succeeded | 1s | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-08-31 23:52:32 UTC
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: QUIET Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (14)
🧰 Additional context used📓 Path-based instructions (7)Review new or changed service boundaries for explicit dependency ownership,⚙️ CodeRabbit configuration file Files:
Review whether tests prove changed behaviour, meaningful error/edge paths, and⚙️ CodeRabbit configuration file Files:
New source files must be TypeScript: flag new JS files as a required change⚙️ CodeRabbit configuration file Files:
Prioritise concrete correctness, security, data-integrity, compatibility,⚙️ CodeRabbit configuration file Files:
Boot owns service initialization; do not📄 CodeRabbit inference engine (AGENTS.md) Files:
New files are TypeScript: Fail if the PR adds a new .js/.jsx/.cjs/.mjs source file, unless it is: a DB📄 CodeRabbit inference engine (Custom checks) Files:
Always use `pnpm`, never npm or Yarn.📄 CodeRabbit inference engine (AGENTS.md) Files:
🔇 Additional comments (3)
WalkthroughEmail replacement definitions now mark server-generated values as trusted. Mailgun HTML bodies use escaped variants for untrusted replacement values and raw values for trusted replacements. Subscription checkout now blocks existing paid members and unauthenticated existing members. Authenticated free, comped, and gift members remain eligible to subscribe. Tests cover email rendering and checkout behavior. Suggested reviewers: Merge Risk: ⚪ Minimal · up to This localized email-validation change is merge-ready after normal checks and review; no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
Full details: Type-Safe BoundariesExplanation No explicit type-safe-boundary failure is introduced. The email changes process replacement definitions and values through existing internal service calls. The checkout change uses the already-derived Full details: New Files Are TypescriptExplanation The pull request adds no new files. The diff from merge base 85fc64e to HEAD contains only modified JavaScript files and one modified snapshot file. Therefore, it does not trigger the failure condition for adding a new .js/.jsx/.cjs/.mjs source file.
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 ast-grep (0.45.2)ghost/core/test/unit/server/services/members/members-api/controllers/router-controller.test.jsast-grep timed out on this file Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #30405 +/- ##
==========================================
- Coverage 76.09% 76.06% -0.04%
==========================================
Files 1679 1679
Lines 160100 160180 +80
Branches 19611 19623 +12
==========================================
+ Hits 121833 121843 +10
- Misses 37282 37352 +70
Partials 985 985
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 participants
no ref