Changed member and comment filters to match post lists - #30424
Conversation
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run @tryghost/admin:test:acceptance |
✅ Succeeded | 7m 54s | View ↗ |
nx run-many -t test:unit -p @tryghost/admin |
✅ Succeeded | 2m 53s | View ↗ |
nx run ghost-monorepo:lint:boundaries |
✅ Succeeded | 25s | View ↗ |
nx run-many -t lint -p @tryghost/admin,ghost-mo... |
✅ Succeeded | 1m 36s | View ↗ |
nx run @tryghost/e2e:test:fixtures |
✅ Succeeded | 1s | View ↗ |
nx run @tryghost/admin:build |
✅ Succeeded | 19s | View ↗ |
nx run-many --target=build --projects=tag:publi... |
✅ Succeeded | <1s | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-09-01 15:10:36 UTC
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: QUIET Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (9)
🧰 Additional context used📓 Path-based instructions (6)Review Admin UI for existing Shade reuse, correct component layer, semantic⚙️ CodeRabbit configuration file Files:
Review lens: "where does this data become trusted?"⚙️ CodeRabbit configuration file Files:
Prioritise concrete correctness, security, data-integrity, compatibility,⚙️ CodeRabbit configuration file Files:
Type-safe boundaries: Fail only if the PR:📄 CodeRabbit inference engine (Custom checks) Files:
Build new features in React,📄 CodeRabbit inference engine (AGENTS.md) Files:
Always use `pnpm`, never npm or Yarn.📄 CodeRabbit inference engine (AGENTS.md) Files:
🔇 Additional comments (1)
Walkthrough
Suggested reviewers: Merge Risk: ⚪ Minimal · up to This PR makes localized visual updates to Members and Comments filters behind the existing posts-list flag while preserving the legacy flag-off controls; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
Full details: Type-Safe BoundariesExplanation PASS. The PR changes only the Comments and Members filter components. The additions use existing UI components, class composition, and the pre-existing Full details: New Files Are TypescriptExplanation PASS: The PR-side diff from the merge's main parent contains only modifications to ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
ref https://linear.app/ghost/issue/PLA-338/post-release-consolidate-filters-ui-in-admin Keep the established filter surfaces visually consistent while the React posts and pages lists are being evaluated, without changing the flag-off experience.
ref https://linear.app/ghost/issue/PLA-338/post-release-consolidate-filters-ui-in-admin Match the compact outlined control used by the React post lists while keeping its accessible label and preserving the flag-off UI.
ref https://linear.app/ghost/issue/PLA-338/post-release-consolidate-filters-ui-in-admin Keep the outlined Clear action visually simple while preserving the existing icon in the flag-off interface.
ref https://linear.app/ghost/issue/PLA-338/post-release-consolidate-filters-ui-in-admin Match the React post list action spacing under the shared flag while retaining the legacy Members layout when it is disabled.
ref https://linear.app/ghost/issue/PLA-338/post-release-consolidate-filters-ui-in-admin Avoid brittle assertions against Tailwind and icon implementation details for a small flag-gated visual alignment.
bfe1de0 to
4a6d065
Compare

ref https://linear.app/ghost/issue/PLA-338/post-release-consolidate-filters-ui-in-admin
Why
The React posts and pages lists introduce updated filter controls. Members and Comments should use the same visual details while that experience is enabled, without changing their existing flag-off UI.
What changed
ListFilterandListFilterPlusin Members and Comments whenpostsListReactis enabledValidation
git diff --checkChecklist