✨ Released Admin 7 page chrome - #30499
Conversation
no ref Milestone 1 has completed private dogfooding, so the refreshed desktop shell and typography should now be available to every eligible Admin user. Remove the Labs registration and toggle, make the rollout boundary independent of Core config, and keep the existing mobile, contributor, and Settings layout boundaries.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: QUIET Plan: Team Run ID: 📒 Files selected for processing (12)
💤 Files with no reviewable changes (6)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (12)
🧰 Additional context used📓 Path-based instructions (7)Review Admin UI for existing Shade reuse, correct component layer, semantic tokens, accessible interaction states, and whole-sentence translations.⚙️ CodeRabbit configuration file Files:
Review whether tests prove changed behaviour, meaningful error/edge paths, and externally observable contracts without coupling to implementation details.⚙️ CodeRabbit configuration file Files:
Review lens: "where does this data become trusted?" Boundary data (HTTP input, external API/SDK responses, env/config, DB/filesystem reads, queue/webhook/event payloads) is `unknown` until validated — Zod by default.⚙️ CodeRabbit configuration file Files:
Prioritise concrete correctness, security, data-integrity, compatibility, and regression risks.⚙️ CodeRabbit configuration file Files:
Type-safe boundaries: Fail only if the PR: consumes boundary data (HTTP input, external API/SDK responses, env/config, DB/filesystem reads, queue/webhook/event payloads) without validating it first — Zod by default, another format only wher...📄 CodeRabbit inference engine (Custom checks) Files:
Build new features in React, use `admin-x-framework` for APIs, and use Shade for UI.📄 CodeRabbit inference engine (AGENTS.md) Files:
Always use `pnpm`, never npm or Yarn.📄 CodeRabbit inference engine (AGENTS.md) Files:
WalkthroughThe Suggested reviewers: Merge Risk: ⚪ Minimal · up to Eligible desktop Admin users receive the Admin 7 shell and typography by default without waiting for Labs configuration, while the existing mobile and eligibility boundaries remain in place. The supplied coverage indicates no remaining merge-blocking risk. 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
Full details: Type-Safe BoundariesExplanation PASS: The PR removes the Full details: New Files Are TypescriptExplanation The pull request adds no files. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run @tryghost/admin:test:acceptance |
❌ Failed | 8m 17s | View ↗ |
nx run ghost:test:ci:integration |
✅ Succeeded | 4m 36s | View ↗ |
nx run ghost:test:integration |
✅ Succeeded | 3m 48s | View ↗ |
nx run ghost:test:ci:e2e |
✅ Succeeded | 4m 14s | View ↗ |
nx run ghost:test:legacy |
✅ Succeeded | 3m 13s | View ↗ |
nx run-many -t test:unit -p @tryghost/admin,ghost |
✅ Succeeded | 3m 32s | View ↗ |
nx run ghost:test:e2e |
✅ Succeeded | 2m 59s | View ↗ |
nx run ghost-monorepo:lint:boundaries |
✅ Succeeded | 22s | View ↗ |
Additional runs (4) |
✅ Succeeded | ... | View ↗ |
💡 Dealing with memory or CPU issues? See memory and CPU details with the resource usage add-on ↗.
☁️ Nx Cloud last updated this comment at 2026-09-03 12:31:15 UTC
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #30499 +/- ##
==========================================
- Coverage 67.49% 67.46% -0.03%
==========================================
Files 1664 1664
Lines 60060 60060
Branches 10386 10386
==========================================
- Hits 40535 40518 -17
- Misses 17236 17254 +18
+ Partials 2289 2288 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Cancelled this PR to separate concerns |
1 participant
What changed
Milestone 1 of the Admin 7.0 project has completed private dogfooding. This makes the new desktop Admin shell and typography the default for eligible users.
admin7PageChromefrom the Core Labs allowlist and Admin private-features UI.Testing
Package-wide Admin lint/typecheck remains blocked by existing errors in unchanged
src/settings/membership/tiers/tier-checkout-collection.tsx.