Implement e-mail sending.

[ricardobeat]

Implements the behaviour described in #53 (comment).

For the tests, I decided to mock the ghost object itself, so they run in a few ms and never touch disk or the database, except for require calls.

There is a ghost.mail.sendWelcomeMessage method, as suggested by @jgable (I think). It should be called during the first run, not sure where that would go.

Suggestions appreciated, I'll continue updating this PR as needed.

[ricardobeat]

Example config (options are passed on to nodemailer):

config.mail = {
    transport: "SMTP",
    options: {
        service: "Mailgun",
        auth: {
            user: "postmaster@xxx.mailgun.org",
            pass: "12345"
        }
    }
};

This might be a good time to remove john@onolan.org from the default settings, lest his inbox will suffer.

[JohnONolan]

+11111

[ErisDS]

The default email address has been changed for any new installs.

👍 This looks wicked, gonna take it for a test run in a bit :)

[jgable]

👍

[ErisDS]

It probably needs some pretty heavy error handling so that this never prevents Ghost from starting up, only from sending emails.

Otherwise it's good to go 👍

[ricardobeat]

Refactored code & rewrote the tests to mock platform detection so that the suite will pass on windows.

Swapped proxyquire with rewire out of necessity. Sinon doesn't have any of these abilities, does it?

I wrote the notifications code, but it is commented out. I'm getting a TypeError: object is not a function from api.js:9 when these are enabled, the Ghost require in this file is returning an empty object. Maybe it's a race condition on require() calls, help wanted.

[ricardobeat]

It probably needs some pretty heavy error handling so that this never prevents Ghost from starting up, only from sending emails.

The deferred being returned is only ever resolved, never rejected, for this reason.

[jgable]

Do you think it could be a circular reference? Requires go like: ghost.js -> mail.js -> api.js -> ghost.js.

At any rate, to get it to work I delayed the require until the mail.init call.

I'm going to take a look at some of this and submit a PR to your branch shortly.

[ricardobeat]

@jgable that's what I thought. please pull again since I just pushed a small refactor

[ricardobeat]

Ok, implemented @jgable's OO refactor from https://github.com/ricardobeat/Ghost/pull/1, added a couple more tests, cleaned everything up and rebased to current master.

[ErisDS]

Sorry for taking so long to get to this.

My config:

config.mail = {
    transport: "SMTP",
    options: {
        service: "Mailgun",
        auth: {
            user: "postmaster@erisds.mailgun.org",
            pass: "***"
        }
    }
};

But I get the error: Error: No e-mail transport configured.

createTransport works correctly, but due to the way this is setup, this.transport is undefined for sendWelcomeMessage and send.

I think this is to do with @jgable's refactor?

I hacked it around a bit to just see if it worked, and I got the following on mailgun:

08/26/13 06:33 PM Failed: ghost-mailer@localhost → ghost@example.com 'Welcome to Ghost' Server response: 500 Invalid MX host
08/26/13 06:33 PM Accepted: ghost-mailer@localhost → ghost@example.com 'Welcome to Ghost'

I assume this is something to do with it running locally on my machine?

[ErisDS]

@javorszky Did you do something to work around this in your PR? I think there should at least be a warning to say the url is invalid and therefore mail can't be sent, although this will require the new config.url thing.

[javorszky]

Um, no. Sendgrid sent my email no problem.

[javorszky]

Oh, I think what you did wrong is not set a host on the config bit.

[ErisDS]

merged via #587 👍