add append option to content helper#6706
Closed
devsnek wants to merge 9 commits intoTryGhost:masterfrom
devsnek:patch-1
Closed
add append option to content helper#6706devsnek wants to merge 9 commits intoTryGhost:masterfrom devsnek:patch-1
devsnek wants to merge 9 commits intoTryGhost:masterfrom
devsnek:patch-1
Conversation
just stopping with no append is silly. lez fix dis.
```{{content characters="250" append="..."```
… statement at this point we can just save some logic and leave things to the try statement. i removed the if statement about whether the variable is declared or not because it will get taken care of by the try statement. #makeitsmall #saveresourecs #savelives
does it really matter how many spaces I have after a line comment? REALLY?????????
Author
|
to be fair the commit labeled "this time it will work" only failed because of the linter. |
Member
|
Hi @GusCaplan, thanks for swinging by! Can I please point you at a reply I wrote on a recent, similar, feature-adding PR here and also at the discussion on this issue which is all about the feature you've proposed and this very related issue TLDR; it's not as simple as it seems but there are some improvements I'd love to see here. |
Author
Author
|
travis build 9225 (commit b349156) failed because of apt-get, not my code. take a look |
Author
|
i'm moving my content pull and my excerpt pull into seperate PRs so this is now closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just stopping with no append is silly. lez fix dis. I added an append option to the helper.
{{content characters="250" append="..."}}{{content characters="250" append="★"}}{{content characters="250" append="A LONG TIME AGO..."}}{{content words="40" append="limiting with words? ohhhhkay...."}}they all work. well.
it works with all the builds and tests that it says to run. i tested it with different ascii/hex/random things and it never failed.