Skip to content

[WIP] add features from #2163#6727

Closed
devsnek wants to merge 1 commit intoTryGhost:masterfrom
devsnek:patch-content
Closed

[WIP] add features from #2163#6727
devsnek wants to merge 1 commit intoTryGhost:masterfrom
devsnek:patch-content

Conversation

@devsnek
Copy link
Copy Markdown

@devsnek devsnek commented Apr 14, 2016

add features from issue #2163

closes #2163

@devsnek
Copy link
Copy Markdown
Author

devsnek commented Apr 14, 2016

@ErisDS I think that this helper should stay simple and not have all that stuff that #5060 suggests. That way, themers have an option depending on what they want to do. Also, I think that append is a feature, not a silly fix to another problem. I think that the option to make a sentence trail off with a '...' instead of rounding to the nearest sentence is a nice look, and I'm sure other people do as well.

Comment thread core/server/helpers/content.js Outdated

This comment was marked as abuse.

@acburdine
Copy link
Copy Markdown
Member

@GusCaplan This needs tests as well.

@devsnek devsnek changed the title add append option to content helper add features from #2163 Apr 18, 2016
@devsnek
Copy link
Copy Markdown
Author

devsnek commented Apr 19, 2016

@acburdine @ErisDS I have written helpers before, and usually you can get the content wrapped in a helper with self, but ghost passes the values differently. What is the ghost way?

@devsnek devsnek changed the title add features from #2163 [WIP] add features from #2163 Apr 19, 2016
@ErisDS ErisDS added the themes label Oct 4, 2016
@kirrg001
Copy link
Copy Markdown
Contributor

@GusCaplan Hey 👋 Thanks for your effort on this 🙂 . This PR is now 1 year old. Can i close this?

@devsnek devsnek closed this Mar 14, 2017
@devsnek devsnek deleted the patch-content branch March 14, 2017 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Have an option 'append' to the content helper

4 participants