Skip to content

Tests cleanup; convert to mocha#70

Merged
ErisDS merged 3 commits into
TryGhost:masterfrom
jgable:testsCleanup
May 26, 2013
Merged

Tests cleanup; convert to mocha#70
ErisDS merged 3 commits into
TryGhost:masterfrom
jgable:testsCleanup

Conversation

@jgable

@jgable jgable commented May 26, 2013

Copy link
Copy Markdown
Contributor
  • Convert existing nodeunit tests to mocha
  • JSLint fixes (Y u no grunt validate before commit?)
  • Remove nodeunit dependencies

ErisDS added a commit that referenced this pull request May 26, 2013
Tests cleanup; convert to mocha
@ErisDS
ErisDS merged commit aae3178 into TryGhost:master May 26, 2013
@jgable
jgable deleted the testsCleanup branch May 26, 2013 19:13
ErisDS pushed a commit that referenced this pull request Aug 28, 2014
ErisDS pushed a commit that referenced this pull request Aug 30, 2014
ErisDS pushed a commit that referenced this pull request Aug 30, 2014
morficus pushed a commit to morficus/Ghost that referenced this pull request Sep 4, 2014
pull Bot pushed a commit to YashRajCodes/Ghost that referenced this pull request Jul 22, 2026
…ilesystems' limits (TryGhost#70)

ref https://linear.app/ghost/issue/ENG-1260
ref https://linear.app/ghost/issue/ENG-1859

- filenames are now generated using a 16-character hash, that gets re-generated on every upload
- we do not check whether the file exists anymore, as the chance of a collision is near zero below a million files in a directory
- if the filename length is higher than what most filesystem accept (255 bytes), we truncate the base of the filename, while keeping space for the unique hash and the file extension. Example to illustrate (non-accurate):
    - input: `long-name-for-an-image-imagine-255bytes-here-blablablablabla-and-a-bit-more.png`
    - output: `long-name-for-an-image-1a2b3c4d5e6f7g890.png`
pull Bot pushed a commit to YashRajCodes/Ghost that referenced this pull request Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants