Bugfix/cda 45 ts vertical datum #1344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rma-bryson
force-pushed
the
bugfix/CDA-45_ts_vertical_datum
branch
from
eba206d to
0328d3d
Compare
rma-rripken
commented
Nov 14, 2025
cwms-data-api/src/main/java/cwms/cda/data/dao/TimeSeriesDaoImpl.java
Outdated
Show resolved
Hide resolved
rma-rripken
commented
Nov 14, 2025
cwms-data-api/src/main/java/cwms/cda/data/dao/TimeSeriesVerticalDatumConverter.java
Outdated
Show resolved
Hide resolved
rma-rripken
commented
Nov 14, 2025
cwms-data-api/src/main/java/cwms/cda/data/dao/TimeSeriesVerticalDatumConverter.java
Outdated
Show resolved
Hide resolved
rma-rripken
commented
Nov 14, 2025
cwms-data-api/src/main/java/cwms/cda/data/dao/TimeSeriesVerticalDatumConverter.java
Outdated
Show resolved
Hide resolved
rma-rripken
commented
Nov 14, 2025
cwms-data-api/src/main/java/cwms/cda/data/dao/TimeSeriesVerticalDatumConverter.java
Outdated
Show resolved
Hide resolved
rma-rripken
commented
Nov 14, 2025
rma-rripken
commented
Nov 14, 2025
cwms-data-api/src/main/java/cwms/cda/data/dao/TimeSeriesDaoImpl.java
Outdated
Show resolved
Hide resolved
rma-bryson
force-pushed
the
bugfix/CDA-45_ts_vertical_datum
branch
from
28f779c to
6ed0f06
Compare
rma-rripken
commented
Nov 17, 2025
Collaborator
Author
rma-rripken
left a comment
rma-rripken
left a comment
There was a problem hiding this comment.
looks good to me
rma-bryson
force-pushed
the
bugfix/CDA-45_ts_vertical_datum
branch
from
d0b8233 to
d6f0b05
Compare
RyanM-RMA
requested changes
Nov 27, 2025
cwms-data-api/src/main/java/cwms/cda/api/TimeSeriesController.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/main/java/cwms/cda/api/TimeSeriesController.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/main/java/cwms/cda/data/dao/TimeSeriesDaoImpl.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/main/java/cwms/cda/data/dao/TimeSeriesVerticalDatumConverter.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/main/java/cwms/cda/data/dao/TimeSeriesVerticalDatumConverter.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/test/java/cwms/cda/api/TimeseriesControllerTestIT.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/test/java/cwms/cda/api/TimeseriesControllerTestIT.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/test/java/cwms/cda/api/TimeseriesControllerTestIT.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/test/java/cwms/cda/api/TimeseriesControllerTestIT.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/test/java/cwms/cda/api/TimeseriesControllerTestIT.java
Outdated
Show resolved
Hide resolved
RyanM-RMA
previously approved these changes
Dec 1, 2025
…nfo when converted. Adds rountrip unit tests.
…r. General code cleanup
…o VerticalDatumInfo/Offset classes
rma-bryson
force-pushed
the
bugfix/CDA-45_ts_vertical_datum
branch
from
4571841 to
3325951
Compare
RyanM-RMA
previously approved these changes
Dec 1, 2025
rma-rripken
commented
Dec 2, 2025
RyanM-RMA
previously approved these changes
Dec 2, 2025
…d some hardcoded values in timeseries controller IT
RyanM-RMA
approved these changes
Dec 2, 2025
rma-kayla
pushed a commit
to rma-kayla/cwms-data-api
that referenced
this pull request
Dec 4, 2025
fixes USACE#1102 --------- Co-authored-by: Bryson Spilman <bryson@rmanet.com>
vairav
added a commit
that referenced
this pull request
Dec 8, 2025
…ilters * origin: Entity endpoint Controller and Integration test (#1497) Enhancements/blob clob query (#1483) Update treafik for latest docker. (#1493) Bugfix/cda 45 ts vertical datum (#1344) CDA-66: Updated TS identifier descriptor paging (#1481) add in missing expiration date to constant/seasonal levels (#1490) 1351 implement cda gui code formatter (#1460) add missing back tic CWMS Data API documentation /timeseries GET endpoints. (#1476) CDA-60: Accept Header Formatting Documentation (#1463) The temp users set needs to be a LinkedHashSet, otherwise the last user in the list isn't always the last user and the paging doesn't work. Add static analysis unit test for Controller classes (#1362) Bugfix/incorrect parameter warning cda 58 (#1470) Test updates for latest schema and correct release schema image. (#1474) CDA-54 - Implements Entity DTO and Dao (#1482) Update npm pacakges (#1478) Correct required java version (#1462) CDA-40: Exception Handling Implementation Updates (#1358)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1102