Keep SSR disabled when motion vectors are off#1113
Closed
pmavridis wants to merge 2 commits into
Closed
Conversation
pmavridis
commented
Jul 2, 2020
| using (new EditorGUI.DisabledScope(!serialized.renderPipelineSettings.supportMotionVectors.boolValue)) | ||
| { | ||
| EditorGUILayout.PropertyField(serialized.renderPipelineSettings.supportSSR, Styles.supportSSRContent); | ||
| serialized.renderPipelineSettings.supportSSR.boolValue &= serialized.renderPipelineSettings.supportMotionVectors.boolValue; |
Contributor
Author
There was a problem hiding this comment.
The alternative is to let supportSSR = true in the asset, but sanitize the frame settings in FrameSettings::Sanitize.
Sanitizing the asset looks better to me because there are many places that query the supportSSR variable from the asset (and not the frame settings).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
When disabling motion vectors on the HDRP asset, but SSR is enabled (in the asset and in the frame settings), we get a black screen and an error.
This PR does not allow enabling SSR (in both the asset and frame settings) when motion vectors are off.
Testing status
Outcome: the screen does not go black and the SSR options are grayed-out in both the asset and frame settings