Skip to content

Keep SSR disabled when motion vectors are off #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pmavridis wants to merge 2 commits into from
Closed

Keep SSR disabled when motion vectors are off #1113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcf75b9
Kee SSR disabled when motion vectors are off
pmavridis Jul 2, 2020
c7dfbea
Revert sanitizing the frame settings - we sanitize the asset, so it i…
pmavridis Jul 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion com.unity.render-pipelines.high-definition/Editor/RenderPipeline/HDRenderPipelineUI.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,12 @@ static void Drawer_SectionCookies(SerializedHDRenderPipelineAsset serialized, Ed

static void Drawer_SectionReflection(SerializedHDRenderPipelineAsset serialized, Editor owner)
{
EditorGUILayout.PropertyField(serialized.renderPipelineSettings.supportSSR, Styles.supportSSRContent);
using (new EditorGUI.DisabledScope(!serialized.renderPipelineSettings.supportMotionVectors.boolValue))
{
EditorGUILayout.PropertyField(serialized.renderPipelineSettings.supportSSR, Styles.supportSSRContent);
serialized.renderPipelineSettings.supportSSR.boolValue &= serialized.renderPipelineSettings.supportMotionVectors.boolValue;
Copy link
Copy Markdown
Contributor Author

@pmavridis pmavridis Jul 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alternative is to let supportSSR = true in the asset, but sanitize the frame settings in FrameSettings::Sanitize.

Sanitizing the asset looks better to me because there are many places that query the supportSSR variable from the asset (and not the frame settings).

}

using (new EditorGUI.DisabledScope(!serialized.renderPipelineSettings.supportSSR.boolValue))
{
EditorGUILayout.PropertyField(serialized.renderPipelineSettings.supportSSRTransparent, Styles.supportSSRTransparentContent);
Expand Down