-
Notifications
You must be signed in to change notification settings - Fork 855
Merge Hd/bugfix #4388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Merge Hd/bugfix #4388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add null check * changelog
* Remove unneeded position from input layout of light cluster * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…4313) * Skip adding the LOD's renderer to the checked renderer if it's null * changelog * Add LODgroup missing renderer to "check scene content for ray tracing" * formatting test * formatting Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…ind will be impacted (#4325) * Update doc * Fix doc
* Fixed an issue where sometime a docked lookdev could be rendered at zero size and break. * Update changelog # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…fers (#4333) * Updated troubleshooting custom pass doc * Update Custom-Pass-Troubleshooting.md
…#4337) * Fixed an issue where runtime debug window UI would leak game objects. * Update changelog
… and view direction is near zero (#4342) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix ray tracing unlit emissive exposure. Changelog * Automated tests coverage * update scenes Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
… DRS is on. (#4346) * Fixing bad pyramid color source texture size. DRS hanlder must be queried since the mip levels depend on the source hardware resolution * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix RTHandle scale bias * Add changelog * Fix history sacle * Fix Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed emission material properties not being animable * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix wrong tile coord calculations * Changelog * Update test scene for contact shadow to cover data * update references screenshots Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
…t come in first frame (#4361) * Fix history buffer allocation for AOVs when the request does not come in first frame * Add a break in the for loop Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…Unsupported on some platforms] (#4356) * Fix for usage of camera color RW when not supported. * Re-enable on metal * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixing bloom bicubic filtering for DRS, bicubic was using the wrong dimensions / texel sizes * Adding better comment to explain offseting of bicubic texture offset fix * update reference screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
sebastienlagarde
added a commit
that referenced
this pull request
May 1, 2021
Merged
sebastienlagarde
added a commit
that referenced
this pull request
May 1, 2021
sebastienlagarde
added a commit
that referenced
this pull request
May 1, 2021
This was referenced May 2, 2021
sebastienlagarde
added a commit
that referenced
this pull request
May 2, 2021
sebastienlagarde
added a commit
that referenced
this pull request
May 29, 2021
* [HDRP][DXR] Add coverage for lighting full screen debug mode in DXR Tests Projects (#4391) * 5 new lighting debug mode scene * RTAO + SSShadows * build settings * Light Cluster scene * Contact shadows correct captures using BackBuffer * ContactShadow scene * forgot meta files * Added information about ray tracing light culling (#4392) * Added ray tracing light culling section and moved a couple of things around * Update Ray-Tracing-Getting-Started.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added more pages to help users with runtime usage #4394 * Disable DXR XR test (#4403) * Add support for lighting full screen debug mode for HDRP tests #4367 * Update CHANGELOG.md * Fix automated tests * upgrade path tracing alpha test * 5001 updated unreadable image * update failing test scene * Update failing scenes * Changing geometry in 708/711 tests It was not appearing for some reasons * Tentative fix * Debug 'debug test scene' * Debug * new DebugDisplaySettings * revert static variable to private * Disable debug test scenes and reverting changes Co-authored-by: Rémi Chapelain <57442369+remi-chapelain@users.noreply.github.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
pastasfuture
pushed a commit
that referenced
this pull request
Aug 20, 2021
* [HDRP][DXR] Add coverage for lighting full screen debug mode in DXR Tests Projects (#4391) * 5 new lighting debug mode scene * RTAO + SSShadows * build settings * Light Cluster scene * Contact shadows correct captures using BackBuffer * ContactShadow scene * forgot meta files * Added information about ray tracing light culling (#4392) * Added ray tracing light culling section and moved a couple of things around * Update Ray-Tracing-Getting-Started.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added more pages to help users with runtime usage #4394 * Disable DXR XR test (#4403) * Add support for lighting full screen debug mode for HDRP tests #4367 * Update CHANGELOG.md * Fix automated tests * upgrade path tracing alpha test * 5001 updated unreadable image * update failing test scene * Update failing scenes * Changing geometry in 708/711 tests It was not appearing for some reasons * Tentative fix * Debug 'debug test scene' * Debug * new DebugDisplaySettings * revert static variable to private * Disable debug test scenes and reverting changes Co-authored-by: Rémi Chapelain <57442369+remi-chapelain@users.noreply.github.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Testing status
Describe what manual/automated tests were performed for this PR
Comments to reviewers
Notes for the reviewers you have assigned.