-
Notifications
You must be signed in to change notification settings - Fork 855
[Backport 10.x.x] Merge Hd/bugfix #4388 #4401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests Projects (#4391) * 5 new lighting debug mode scene * RTAO + SSShadows * build settings * Light Cluster scene * Contact shadows correct captures using BackBuffer * ContactShadow scene * forgot meta files
* Added ray tracing light culling section and moved a couple of things around * Update Ray-Tracing-Getting-Started.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
It was not appearing for some reasons
phocodes
approved these changes
May 27, 2021
remi-chapelain
approved these changes
May 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deactivated Debug tests for now.
All remaining tests are passing ✔️
Ready to merge.
pastasfuture
pushed a commit
that referenced
this pull request
Aug 20, 2021
* [HDRP][DXR] Add coverage for lighting full screen debug mode in DXR Tests Projects (#4391) * 5 new lighting debug mode scene * RTAO + SSShadows * build settings * Light Cluster scene * Contact shadows correct captures using BackBuffer * ContactShadow scene * forgot meta files * Added information about ray tracing light culling (#4392) * Added ray tracing light culling section and moved a couple of things around * Update Ray-Tracing-Getting-Started.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added more pages to help users with runtime usage #4394 * Disable DXR XR test (#4403) * Add support for lighting full screen debug mode for HDRP tests #4367 * Update CHANGELOG.md * Fix automated tests * upgrade path tracing alpha test * 5001 updated unreadable image * update failing test scene * Update failing scenes * Changing geometry in 708/711 tests It was not appearing for some reasons * Tentative fix * Debug 'debug test scene' * Debug * new DebugDisplaySettings * revert static variable to private * Disable debug test scenes and reverting changes Co-authored-by: Rémi Chapelain <57442369+remi-chapelain@users.noreply.github.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Testing status
Describe what manual/automated tests were performed for this PR
Comments to reviewers
Notes for the reviewers you have assigned.