Fixed performance problem of ShaderPreprocessor #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
List.RemoveAt method would copy the elements around, doing so in a huge iteration breaks the performance
phi-lira
reviewed
May 14, 2020
phi-lira
reviewed
May 14, 2020
| } | ||
| compilerDataList.Clear(); | ||
| foreach(var i in final) | ||
| compilerDataList.Add(i); |
There was a problem hiding this comment.
I'm worried about this solution, the list here might still be huge. I've looked at HDRP solution.
They do it in place with a single list. Instead of removing, they swap i with last item. Then they decrement last item index. At the end, they remove all elements at once from last item index to list size. Would you be interested in looking at this solution and comparing performance?
// here's the HDRP code, ignore the inner loop about asset
https://github.com/Unity-Technologies/Graphics/blob/master/com.unity.render-pipelines.high-definition/Editor/BuildProcessors/HDRPPreprocessShaders.cs#L256-L295
There was a problem hiding this comment.
Actually the size of the list is the final result, I think it can't be reduced further more? it only adds the variants which are not striped, but sure I'd like to take a look at the implementation of HDRP
There was a problem hiding this comment.
The implementation of HDRP is indeed better, so I modified the PR to adopt HDRP's way for doing it
phi-lira
approved these changes
May 15, 2020
phi-lira
changed the base branch from
master
to
universal/improve-shader-stripping
|
Changed base to a local branch so we run test automation. Thanks for adding changelog! |
phi-lira
merged commit 750e587
into
Unity-Technologies:universal/improve-shader-stripping
phi-lira
added a commit
that referenced
this pull request
May 26, 2020
* Fixed performance problem of ShaderPreprocessor List.RemoveAt method would copy the elements around, doing so in a huge iteration breaks the performance * Added changlog for shader preprocessor fix * Improved the variant striping * Fixed typo Co-authored-by: liiir1985 <liiir1985@users.noreply.github.com>
phi-lira
added a commit
that referenced
this pull request
May 27, 2020
* Fixed performance problem of ShaderPreprocessor List.RemoveAt method would copy the elements around, doing so in a huge iteration breaks the performance * Added changlog for shader preprocessor fix * Improved the variant striping * Fixed typo Co-authored-by: liiir1985 <liiir1985@users.noreply.github.com>
phi-lira
added a commit
that referenced
this pull request
May 27, 2020
* Fixed performance problem of ShaderPreprocessor List.RemoveAt method would copy the elements around, doing so in a huge iteration breaks the performance * Added changlog for shader preprocessor fix * Improved the variant striping * Fixed typo Co-authored-by: liiir1985 <liiir1985@users.noreply.github.com> # Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md
phi-lira
added a commit
that referenced
this pull request
May 27, 2020
* Fixed performance problem of ShaderPreprocessor List.RemoveAt method would copy the elements around, doing so in a huge iteration breaks the performance * Added changlog for shader preprocessor fix * Improved the variant striping * Fixed typo Co-authored-by: liiir1985 <liiir1985@users.noreply.github.com> Co-authored-by: liiir1985 <liiir1985@users.noreply.github.com>
phi-lira
added a commit
that referenced
this pull request
May 27, 2020
* Fixed performance problem of ShaderPreprocessor List.RemoveAt method would copy the elements around, doing so in a huge iteration breaks the performance * Added changlog for shader preprocessor fix * Improved the variant striping * Fixed typo Co-authored-by: liiir1985 <liiir1985@users.noreply.github.com> # Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md # Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md
Kleptine
pushed a commit
to Pontoco/Graphics
that referenced
this pull request
Jul 16, 2020
…) (Unity-Technologies#500) * Fixed performance problem of ShaderPreprocessor List.RemoveAt method would copy the elements around, doing so in a huge iteration breaks the performance * Added changlog for shader preprocessor fix * Improved the variant striping * Fixed typo Co-authored-by: liiir1985 <liiir1985@users.noreply.github.com> # Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md # com.unity.render-pipelines.universal/Editor/ShaderPreprocessor.cs
Kleptine
pushed a commit
to Pontoco/Graphics
that referenced
this pull request
Jul 16, 2020
…) (Unity-Technologies#500) * Fixed performance problem of ShaderPreprocessor List.RemoveAt method would copy the elements around, doing so in a huge iteration breaks the performance * Added changlog for shader preprocessor fix * Improved the variant striping * Fixed typo Co-authored-by: liiir1985 <liiir1985@users.noreply.github.com> # Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md # com.unity.render-pipelines.universal/Editor/ShaderPreprocessor.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List.RemoveAt method would copy the elements around, doing so in a huge enumeration breaks the performance,
Purpose of this PR
Testing status
Manual Tests