Fixed performance problem of ShaderPreprocessor (#470) #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed performance problem of ShaderPreprocessor List.RemoveAt method would copy the elements around, doing so in a huge iteration breaks the performance * Added changlog for shader preprocessor fix * Improved the variant striping * Fixed typo
phi-lira
added a commit
that referenced
this pull request
May 27, 2020
* Fixed performance problem of ShaderPreprocessor List.RemoveAt method would copy the elements around, doing so in a huge iteration breaks the performance * Added changlog for shader preprocessor fix * Improved the variant striping * Fixed typo Co-authored-by: liiir1985 <liiir1985@users.noreply.github.com>
phi-lira
added a commit
that referenced
this pull request
May 27, 2020
* Fixed performance problem of ShaderPreprocessor List.RemoveAt method would copy the elements around, doing so in a huge iteration breaks the performance * Added changlog for shader preprocessor fix * Improved the variant striping * Fixed typo Co-authored-by: liiir1985 <liiir1985@users.noreply.github.com> # Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md
phi-lira
added a commit
that referenced
this pull request
May 27, 2020
* Fixed performance problem of ShaderPreprocessor List.RemoveAt method would copy the elements around, doing so in a huge iteration breaks the performance * Added changlog for shader preprocessor fix * Improved the variant striping * Fixed typo Co-authored-by: liiir1985 <liiir1985@users.noreply.github.com> Co-authored-by: liiir1985 <liiir1985@users.noreply.github.com>
phi-lira
added a commit
that referenced
this pull request
May 27, 2020
* Fixed performance problem of ShaderPreprocessor List.RemoveAt method would copy the elements around, doing so in a huge iteration breaks the performance * Added changlog for shader preprocessor fix * Improved the variant striping * Fixed typo Co-authored-by: liiir1985 <liiir1985@users.noreply.github.com> # Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md # Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md
ellioman
added
backported-7.x
backported-8.x
and removed
needs-backport-7.x
needs-backport-8.x
labels
Kleptine
pushed a commit
to Pontoco/Graphics
that referenced
this pull request
Jul 16, 2020
…) (Unity-Technologies#500) * Fixed performance problem of ShaderPreprocessor List.RemoveAt method would copy the elements around, doing so in a huge iteration breaks the performance * Added changlog for shader preprocessor fix * Improved the variant striping * Fixed typo Co-authored-by: liiir1985 <liiir1985@users.noreply.github.com> # Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md # com.unity.render-pipelines.universal/Editor/ShaderPreprocessor.cs
Kleptine
pushed a commit
to Pontoco/Graphics
that referenced
this pull request
Jul 16, 2020
…) (Unity-Technologies#500) * Fixed performance problem of ShaderPreprocessor List.RemoveAt method would copy the elements around, doing so in a huge iteration breaks the performance * Added changlog for shader preprocessor fix * Improved the variant striping * Fixed typo Co-authored-by: liiir1985 <liiir1985@users.noreply.github.com> # Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md # com.unity.render-pipelines.universal/Editor/ShaderPreprocessor.cs
|
@phi-lira you labelled this with needs-backport-9.x and that label is no longer on this PR, but this has not been merged into 9.x.x/release. Can we get a backport to 9.x.x? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guide : https://github.com/Unity-Technologies/Graphics/blob/master/.github/pr-read.png.md
Display Addon : https://userstyles.org/styles/182991/unity-graphics-pr-readme
Purpose of this PR
Improves shader stripping by optimizing shader preprocessor.
Testing status
Manual Tests
Not done.
Automated Tests
Not needed. Automation will already tell improved build time.
Links
Yamato: (Select your branch) https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics
Comments to reviewers
This PR is mapped from external PR: #470
Solution is based on HDRP one.