Skip to content

Conversation

phi-lira
Copy link
Contributor

Backport of #500

* Fixed performance problem of ShaderPreprocessor

List.RemoveAt method would copy the elements around, doing so in a huge iteration breaks the performance

* Added changlog for shader preprocessor fix

* Improved the variant striping

* Fixed typo

Co-authored-by: liiir1985 <liiir1985@users.noreply.github.com>
@phi-lira phi-lira requested a review from a team as a code owner May 27, 2020 09:45
@phi-lira phi-lira requested a review from eh-unity May 27, 2020 09:45
Copy link
Contributor

@eh-unity eh-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@phi-lira phi-lira merged commit 8190ab0 into 8.x.x/release May 27, 2020
@phi-lira phi-lira deleted the 8.x.x/universal/improve-shader-stripper branch May 27, 2020 12:45
@sebastienlagarde sebastienlagarde mentioned this pull request Jun 2, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants