Skip to content

HDRP Template for 2020.2 Alpha#671

Closed
AQ-u3D wants to merge 14 commits into
masterfrom
HD_template_2020
Closed

HDRP Template for 2020.2 Alpha#671
AQ-u3D wants to merge 14 commits into
masterfrom
HD_template_2020

Conversation

@AQ-u3D
Copy link
Copy Markdown
Contributor

@AQ-u3D AQ-u3D commented May 29, 2020

Please read

PR workflow guidelines

  • SRP ABV will start automatically on Yamato when you open your PR
  • Changes to docs and md files will not trigger ABV jobs
  • Consider making use of draft PRs if you are not 100% sure that your PR is ready for review
  • ABV will restart if you add a new commit to a branch with an open PR (hence why you should consider using draft PRs)
  • Adding [skip ci] (case insensitive) to the title of PRs will stop any jobs being trigger automatically - you will need to open Yamato and find your branch to run ABV
  • You can also add [skip ci] to commit messages to prevent CI from running on that push
  • Add [cancel old ci] to your commit message if you've made changes you want to test and no longer need the previous jobs

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?

New HDRP Template. Commit made for 2020.2 Alpha

Testing status

Manual Tests: What did you do?

  • Opened test project + Run graphic tests locally
  • Built a player
  • Checked new UI names with UX convention
  • Tested UI multi-edition + Undo/Redo + Prefab overrides + Alignment in Preset
  • C# and shader warnings (supress shader cache to see them)
  • Checked new resources path for the reloader (in developer mode, you have a button at end of resources that check the paths)
  • Other:

Automated Tests: What did you setup? (Add a screenshot or the reference image of the test please)

Yamato: (Select your branch):
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics

Any test projects to go with this to help reviewers?

Comments to reviewers

Notes for the reviewers you have assigned.

Please let me know if I need to specify anything for the above. Thanks.

AQ-u3D added 14 commits March 30, 2020 11:12
@AQ-u3D
First Commit for New HDRP template
a9849e1 
First commit for the new HDRP template being worked on by the Asset Store Team
@AQ-u3D
Texture Update
d630d18 
Updated some of the textures to be of a smaller resolution, rebake lightmaps. WIP at the moment.
@AQ-u3D
WIP
22ce210 
Added new and tweaked textures. Cleaned up environment asset and renamed it accordingly. Remove other unused textures and materials.
@AQ-u3D
Commit
5fa9490 
Added new Marble Texture set, and breaking up of main example asset environment so composition and placement of assets can be tested in engine easily.
@AQ-u3D
Texture Changes
91fda2f
@AQ-u3D
Update Marble_BC.png
63fbd25
@AQ-u3D
Commit
05a05ba
@AQ-u3D
Commit
f878473
@AQ-u3D
Commit
8329c49
@AQ-u3D
Commit
fd85db7 
Changes to Edge Decal Alpha. Did new woodplanks texture set to test.
@AQ-u3D
Asset Changes
1b3e777 
-Added Woodplanks texture and material and apply it to first room.
-Clean up bonsai textures/material.
-Added a bit of metallic trim to steps to test ( will require a specific metal trim texture to make it nice.
-Adjustments to fog settings per room
@AQ-u3D
Commit
90bdb12
@AQ-u3D
Update EdgeDecals_BC.tga
516237d
@AQ-u3D
Commit for Alpha
1361710 
Replace old files with current updated project. Added in the density volume feedback from today's meeting. Left with additional art tasks and lighting fixes to resolve
@AQ-u3D AQ-u3D added the HDRP label May 29, 2020
@AQ-u3D AQ-u3D self-assigned this May 29, 2020
@AQ-u3D AQ-u3D requested a review from sebastienlagarde June 8, 2020 08:24
@sebastienlagarde sebastienlagarde mentioned this pull request Jun 11, 2020
Merged
6 tasks
@sebastienlagarde
Copy link
Copy Markdown
Contributor

sebastienlagarde commented Jun 11, 2020

Replace by #868 => update to latest master

@pierre-unity pierre-unity deleted the HD_template_2020 branch November 11, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebastienlagarde sebastienlagarde Awaiting requested review from sebastienlagarde

Assignees

@AQ-u3D AQ-u3D

Labels

HDRP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AQ-u3D @sebastienlagarde