Skip to content

Update HDRP Template for 2020.2 [Skip CI]#868

Merged
sebastienlagarde merged 34 commits into
masterfrom
HDRP/template2020
Jun 20, 2020
Merged

Update HDRP Template for 2020.2 [Skip CI]#868
sebastienlagarde merged 34 commits into
masterfrom
HDRP/template2020

Conversation

@sebastienlagarde
Copy link
Copy Markdown
Contributor

@sebastienlagarde sebastienlagarde commented Jun 11, 2020

Purpose of this PR

This PR update the current HDRP template to be like:

TODO: need to update controller and text

Replace PR: #671 - update to latest version of master


Testing status

Manual Tests: What did you do?

  • Opened test project + Run graphic tests locally
  • Built a player
  • Checked new UI names with UX convention
  • Tested UI multi-edition + Undo/Redo + Prefab overrides + Alignment in Preset
  • C# and shader warnings (supress shader cache to see them)
  • Checked new resources path for the reloader (in developer mode, you have a button at end of resources that check the paths)
  • Other:

Automated Tests: What did you setup? (Add a screenshot or the reference image of the test please)

Yamato: (Select your branch):
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics

Any test projects to go with this to help reviewers?


Comments to reviewers

Notes for the reviewers you have assigned.

AQ-u3D and others added 17 commits March 30, 2020 11:12
First commit for the new HDRP template being worked on by the Asset Store Team
Updated some of the textures to be of a smaller resolution, rebake lightmaps. WIP at the moment.
Added new and tweaked textures. Cleaned up environment asset and renamed it accordingly. Remove other unused textures and materials.
Added new Marble Texture set, and breaking up of main example asset environment so composition and placement of assets can be tested in engine easily.
Changes to Edge Decal Alpha. Did new woodplanks texture set to test.
-Added Woodplanks texture and material and apply it to first room.
-Clean up bonsai textures/material.
-Added a bit of metallic trim to steps to test ( will require a specific metal trim texture to make it nice.
-Adjustments to fog settings per room
Replace old files with current updated project. Added in the density volume feedback from today's meeting. Left with additional art tasks and lighting fixes to resolve
@iM0ve
Copy link
Copy Markdown
Contributor

iM0ve commented Jun 12, 2020

As I understand this is not the latest version, will take a look when updated

Affected most of the visual changes from feedback. Now the template runs in a indirect baked mode with a mixed Directional Light that users can turn. The light is using distance shadowmasked so at close up it's using real-time shadows. Removed old assets that are no longer used and added the new bamboo setpiece. Additional setdressing in the form of decals/lights to the first room. Overall setup cleanup to present a cleaner setup of the scene setup and volumes as per feedback, and make sure there are no confusing settings. Also quickly tested that the scene can run with a simple camera controller.
@AQ-u3D
Copy link
Copy Markdown
Contributor

AQ-u3D commented Jun 17, 2020

I've just committed the latest updates based on prior feedback to the PR.

Adjusted the contact shadows of some of the volumes, rectified leaks with an additional shadowproxy mesh, and baking adjustments. Tweaked the smoothness of the wood material as well. Found another issue with the LODs of the small ceiling lights that needed adjustments.
@iM0ve
Copy link
Copy Markdown
Contributor

iM0ve commented Jun 18, 2020

Can we delete the folder called Presets? Or it serves some purpose?

@sebastienlagarde
Copy link
Copy Markdown
Contributor Author

Added FPS controller and tested various collision sceneario cases. Added box collider everywhere it was an issue. Updated the readme.asset. There is still polish to do on this template, but good to merge

@sebastienlagarde sebastienlagarde merged commit ba3fdeb into master Jun 20, 2020
@sebastienlagarde sebastienlagarde deleted the HDRP/template2020 branch June 20, 2020 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants