CHANGE: Added Windows Input tests to ensure Mouse movement works usin…#1080
Merged
CHANGE: Added Windows Input tests to ensure Mouse movement works usin…#1080
Conversation
Collaborator
Author
|
The tests are expected to fail until the fix lands |
Rene-Damm
reviewed
Mar 4, 2020
Contributor
Rene-Damm
left a comment
Rene-Damm
left a comment
There was a problem hiding this comment.
Since this goes end-to-end, would prefer to have this as part of IntegrationTests.
Also, I assume this can't land until we've landed the fix on the native side?
| [Category("WindowsInput")] | ||
| public IEnumerator WindowsInput_RemoteDesktopMouseMovements_AreDetected() | ||
| { | ||
| var mouse = InputSystem.GetDevice<Mouse>(); |
Collaborator
Author
There was a problem hiding this comment.
You want it moved into the IntegrationTests folder?
Collaborator
Author
|
Wont be able to backport this fix further than 2019.3 so these tests wont pass. Ill have a think about a solution, maybe move the test into trunk. |
The fix is not available in lower versions.
Due to error in tests [UPM-CI-UTILS] ERROR - Usage of Bintray registry https://api.bintray.com/npm/unity/unity-npm will become obsolete by May 2020. Please, change the npm url https://api.bintray.com/npm/unity/unity-npm in /Users/builduser/build/output/Unity-Technologies/InputSystem/.yamato/upm-ci.yml for 'https://artifactory.prd.cds.internal.unity3d.com/artifactory/api/npm/upm-npm'
js-dignitas
added a commit
to js-dignitas/InputSystem
that referenced
this pull request
Jul 5, 2021
* github/develop: CHANGE: Move Unity min version up to 2019.4 LTS (Unity-Technologies#1168). FIX: Stack overflow in SwithCurrentActionMap (case 1232893, Unity-Technologies#1164). FIX: Gravity, LinearAcceleration, and Attitude not initialized on iOS (case 1251382, Unity-Technologies#1160). FIX: Control picker empty when using 'Supported Devices' (case 1254150, Unity-Technologies#1163). NEW: Add concept of 'precompiled layouts' (Unity-Technologies#1156). FIX: Missing HelpURLs (Unity-Technologies#1157). FIX: Actions not triggering with axis controls that have no limits (Unity-Technologies#1128). FIX: Broken CI (Unity-Technologies#1159). FIX: CHANGELOG dates not conforming to ISO 8601 (Unity-Technologies#1141). FIX: No input coming through in UnityTests (Unity-Technologies#1139). FIX: Drag-reordering losing bindings (case 1228000, Unity-Technologies#1150). CHANGE: Added Windows Input tests to ensure Mouse movement works usin… (Unity-Technologies#1080) FIX: Broken CI from NPM server changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a test to go with the fix in https://ono.unity3d.com/unity/unity/pull-request/102187/_/se/input/rdp-mouse-position-fix
CHANGE: Added Windows Input tests to ensure Mouse movement works using RDP.