FIX: Integration tests CI instability on Integration_CanSendAndReceiveEvents #1693
Merged
jfreire-unity merged 2 commits intodevelopfrom Jun 26, 2023
Merged
Conversation
This makes the devices adding during tests to be enabled regardless of the standalone player application focus.
ritamerkl
approved these changes
Jun 23, 2023
lyndon-unity
approved these changes
Jun 23, 2023
Collaborator
lyndon-unity
left a comment
There was a problem hiding this comment.
Looks like a nice targeted fix for the issue. Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the CI instability reported in ISX-1381, where
Integration_CanSendAndReceiveEventswould fail.Changes made
Locally, the test failed because sometimes the device state was not updated. This was because the device was seen as "disabled"), thus not updating its state. The reason why the device was disabled is that sometimes the test player didn't have "game focus" (see [1] and [2].)
On macOS, I've seen this happening due to the "accept incoming connection" pop-up, and on Windows a similar pop-up appeared.
By setting the background behavior settings to InputSettings.BackgroundBehavior.IgnoreFocus, the test always passed locally.
Notes
Please write down any additional notes, remove the section if not applicable.
Checklist
Before review:
Changed,Fixed,Addedsections.([case %number%](https://issuetracker.unity3d.com/issues/...)).Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.