Skip to content

FIX: Integration tests CI instability on Integration_CanSendAndReceiveEvents #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfreire-unity merged 2 commits into from
Jun 26, 2023
Merged

FIX: Integration tests CI instability on Integration_CanSendAndReceiveEvents #1693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e017c28
Set background settings to ignore focus
jfreire-unity Jun 23, 2023
0241d4a
Update CHANGELOG
jfreire-unity Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Packages/com.unity.inputsystem/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ however, it has to be formatted properly to pass verification tests.

### Fixed
- Fixed UI clicks not registering when OS provides multiple input sources for the same event, e.g. on Samsung Dex (case ISX-1416, ISXB-342).
- Fixed unstable integration test `Integration_CanSendAndReceiveEvents` by ignoring application focus on integration tests. (case ISX-1381)

## [1.6.1] - 2023-05-26

Expand Down
16 changes: 16 additions & 0 deletions Packages/com.unity.inputsystem/Tests/IntegrationTests/IntegrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,22 @@ public static void PreserveMethods()
var dummy = new System.ComponentModel.StringConverter();
}

[SetUp]
public virtual void Setup()
{
// The standalone player can go out of focus when running tests. This makes the devices added during tests set
// as disabled. Which in turn makes the InputSystem update not process input state changes for devices.
// By ignoring focus, we can protect ourselves against this and always update the device state in the standalone
// test players
InputSystem.settings.backgroundBehavior = InputSettings.BackgroundBehavior.IgnoreFocus;
}

[TearDown]
public virtual void TearDown()
{
InputSystem.settings.backgroundBehavior = default;
}

[Test]
[Category("Integration")]
public void Integration_CanSendAndReceiveEvents()
Expand Down