Skip to content

Conversation

@Elfi0Kuhndorf
Copy link
Contributor

Description

I removed the LODs on the small stepping stones as those caused the lighting issues (swapping from dark to light) when zooming with the camera. As those stones are really small it is not necessary to have LODs on them, but I ended up keeping the LOD0 assets from them, as this way the lighting on them looked the best.

Issue Number(s)

https://jira.unity3d.com/browse/MTTB-546?filter=-1

Contribution checklist

  • Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@Elfi0Kuhndorf Elfi0Kuhndorf requested a review from a team as a code owner November 22, 2024 15:14
@Elfi0Kuhndorf Elfi0Kuhndorf added the good first issue Good for newcomers label Nov 22, 2024
@hammerlerobi hammerlerobi self-assigned this Nov 27, 2024
Copy link
Contributor

@hammerlerobi hammerlerobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why we not remove the LODs directly on the Rock Prefabs but instead removed them as Prefab overrides in multiple scenes? I still see the LOD poping on the big rocks. Besides that I think its a good improvement 👍

@Elfi0Kuhndorf
Copy link
Contributor Author

Any reason why we not remove the LODs directly on the Rock Prefabs but instead removed them as Prefab overrides in multiple scenes? I still see the LOD poping on the big rocks. Besides that I think its a good improvement 👍

I did not want to remove the LODs from the big rocks, as Vlad added them initially to help the performance. For them to pop less we could adjust the distance settings when an LOD swaps. For the small stones I felt LODs are overkill and simultaneously it was a good way to get rid of the light/dark issue.

Copy link
Contributor

@hammerlerobi hammerlerobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Elfi0Kuhndorf Elfi0Kuhndorf merged commit 374459c into develop Dec 3, 2024
29 checks passed
@Elfi0Kuhndorf Elfi0Kuhndorf deleted the fix/distributed-authority-sample/fix-small-stones-light-differences branch December 3, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants