SetInScenePlaced marks runtime instantiated NetworkObjects as InScenePlaced

[ffejlersen]

Description

A clear and concise description of what the bug is.

Reproduce Steps

1. Go to 'NGO_Setup'
2. Start play mode
3. Click on 'Start Host'
4. Click on the keyboard button "L" to load an additive scene with a spawner object
   • Console prints instance InScenePlaced state as False
5. Click on the keyboard button "D" to print current state of spawned object

• Console prints instance InScenePlaced state as True

Expected Outcome

Network objects instantiated during runtime should not be marked as InScenePlaced = true.
Before the introduction of SetInScenePlaced it was allowed to instantiate network objects from Awake.

Environment

• OS: Windows 11
• Unity Version: 6000.3.6f1
• Netcode Version: 2.13.1
• Netcode Topology: Client-Server

Unity Project

UnityProject.zip

[NoelStephensUnity]

Hi @ffejlersen,

Thank you for your submission and the replication project as it greatly helped me narrow down the issue.

If you dynamically instantiate something and then immediately disable the root GameObject, in order for any netcode related property to be accurate you will need to make sure:

• The root GameObject is active in the hierarchy.
• The NetworkObject has been spawned.

Make this adjustment in your FooSpawner:

    private void Update()
    {        
        if (Keyboard.current.dKey.wasPressedThisFrame)
        {
              // Enable it.
            _instance.gameObject.SetActive(true);

             // Spawn it.             
            _instance.GetComponent<NetworkObject>().Spawn();

            // Log the netcode fields or properties you want to check
            Debug.Log($"{_instance.name} now has in-scene-placed value of: {_instance.GetComponent<NetworkObject>().InScenePlaced}");
        }
    }

The related values of things that could be calculated during the spawn process are most likely not going to be accurate until it is spawned. The in-scene placed flag you are seeing when it is still disabled and not spawned lets us know you have pre-instantiated something into a scene, that is most likely still loading, and that (along with other information) allows us to determine that it should be treated as a dynamically spawned object. Once it is spawned, it should reflect the correct values.

Let me know if this resolves your issue?