Skip to content

chore: change ghostadapter to ghostobject#4105

Merged
NoelStephensUnity merged 2 commits into
develop-3.x.xfrom
chore/change-ghostadapter-to-ghostobject
Jul 24, 2026
Merged

chore: change ghostadapter to ghostobject#4105
NoelStephensUnity merged 2 commits into
develop-3.x.xfrom
chore/change-ghostadapter-to-ghostobject

Conversation

@NoelStephensUnity

Copy link
Copy Markdown
Member

Purpose of this PR

Changing GhostAdapter to GhostObject

Jira ticket

Link to related jira ticket (Use the smart commits). Short version (e.g. MTT-123) also works and gets auto-linked

Changelog

  • Added: The package whose Changelog should be added to should be in the header. Delete the changelog section entirely if it's not needed.
  • Fixed: If you update multiple packages, create a new section with a new header for the other package.
  • Removed/Deprecated/Changed: Each bullet should be prefixed with Added, Fixed, Removed, Deprecated, or Changed to indicate where the entry should go.

Documentation

  • No documentation changes or additions were necessary.
  • Includes documentation for previously-undocumented public API entry points.
  • Includes edits to existing public API documentation.

Testing & QA (How your changes can be verified during release Playtest)

Functional Testing

Manual testing :

  • Manual testing done

Automated tests:

  • Covered by existing automated tests
  • Covered by new automated tests

Does the change require QA team to:

  • Review automated tests?
  • Execute manual tests?
  • Provide feedback about the PR?

If any boxes above are checked the QA team will be automatically added as a PR reviewer.

Up-port

N/A

Backports

N/A

Changing GhostAdapter to GhostObject
More GhostAdapter to GhostObject changes
@NoelStephensUnity
NoelStephensUnity requested a review from a team as a code owner July 24, 2026 22:30
@NoelStephensUnity
NoelStephensUnity enabled auto-merge (squash) July 24, 2026 22:31
@codecov-github-com

codecov-github-com Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

@@                Coverage Diff                @@
##           develop-3.x.x    #4105      +/-   ##
=================================================
+ Coverage          70.44%   70.47%   +0.03%     
=================================================
  Files                146      146              
  Lines              23275    23276       +1     
=================================================
+ Hits               16396    16404       +8     
+ Misses              6879     6872       -7     
Flag Coverage Δ
NGOv2_ubuntu_6000.3 70.47% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...de.gameobjects/Runtime/Connection/NetworkClient.cs 87.50% <100.00%> (+0.26%) ⬆️
....netcode.gameobjects/Runtime/Core/NetworkObject.cs 64.04% <ø> (ø)
...ts/Runtime/Messaging/Messages/ParentSyncMessage.cs 93.47% <ø> (ø)
...cts/Runtime/SceneManagement/NetworkSceneManager.cs 31.07% <ø> (+0.32%) ⬆️

... and 4 files with indirect coverage changes

Components Coverage Δ
com.unity.netcode.gameobjects 70.47% <100.00%> (+0.03%) ⬆️

ℹ️ Need help interpreting these results?

@NoelStephensUnity
NoelStephensUnity merged commit ad36f93 into develop-3.x.x Jul 24, 2026
26 checks passed
@NoelStephensUnity
NoelStephensUnity deleted the chore/change-ghostadapter-to-ghostobject branch July 24, 2026 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants