fix: Fix the crash when calling the ReplaceTrack method using NvCodec #737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 58500641455e4f7bec3e48380e0fee30e138dfbb)
karasusan
changed the title
kannan-xiao4
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue Unity-Technologies/UnityRenderStreaming#626
Fixed a crash during
ReplaceTrackmethod. The cause of the crash was that the decoder was not accepting resolution changes.The
NvDecoderclass calls theNvDecoder::ReconfigureDecodermethod when it detects a resolution change in theNvDecoder::Decodemethod. However, the resolution change requires a prior call to theNvDecoder::setReconfigParamsmethod, which must be called before theNvDecoder::Decodemethod is called. To detect a change in resolution, the resolution information is obtained from the SPS.