Remove AsBuffer accessors and regenerate test code - #12
Merged
Conversation
joejo-unity
approved these changes
Sep 2, 2026
paw9000Unity
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the custom
AsBufferaccessors from the generated Swift code, along with thegetBufferPointermethod inTable.swiftthat they call.The checked-in test code has also been regenerated. It carries two sets of changes beyond the
AsBufferremoval:The Swift baselines (
monster_test_generated.swift) pick upbit_flagsenums becomingOptionSetstructs. That codegen change landed in Update to v25.12.19 #9, but the baselines were never regenerated, so this catches them up.tests/union_vector/union_vector_generated.hloses 27 lines ofGetFullyQualifiedNamemethods. These are not something this fork generates: the recipe for that file inscripts/generate_code.pydoes not pass--gen-name-strings, and upstream removed the same 27 lines in [TS/JS] Move TS tests to dedicated folder and deps upgrade google/flatbuffers#7508. Our copy kept them through a merge, and regenerating drops them.Added a Yamato job that runs
scripts/check_generate_code.pyandscripts/check-grpc-generated-code.pyalongside theflatcartifact builds, wired intoBuild All, so stale generated code fails the build instead of going unnoticed.