Skip to content

fix: redirect index to new play page#414

Merged
harbassan merged 1 commit into
masterfrom
vps-72-get-rid-of-the-old-play-page
Jun 16, 2026
Merged

fix: redirect index to new play page#414
harbassan merged 1 commit into
masterfrom
vps-72-get-rid-of-the-old-play-page

Conversation

@hazikchaudhry

@hazikchaudhry hazikchaudhry commented May 26, 2026

Copy link
Copy Markdown
Contributor

Issue

The website was directing to the old play page

Solution

the default url now re-directs to the new play page, using the same naming routes as the rest of the routes

/play -> play page
/create -> create scenario
/dashboard -> dashboard access

Risk

I havent fully testing it, so it should be fine but it depends. But it should work, unless there is a freaky bug

Checklist

  • Acceptance criteria met
  • Wiki documentation is written and up to date
  • Unit tests written and passing
  • Integration tests written and passing
  • Continuous integration build passing

Summary by CodeRabbit

  • Navigation Updates
    • Modified application routing structure; the home page now redirects to the play section instead of displaying the scenario selection interface.

@linear

linear Bot commented May 26, 2026

Copy link
Copy Markdown

VPS-72

@harbassan

Copy link
Copy Markdown
Contributor

just delete the old page 😭 get that piece of shit out of our codebase pls

@harbassan harbassan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hazikchaudhry read my comment

@harbassan
harbassan force-pushed the vps-72-get-rid-of-the-old-play-page branch from 068c676 to 27eefa2 Compare June 16, 2026 06:28
@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

App.jsx router configuration is updated: Redirect is added to the react-router-dom import, ScenarioSelectionPage is removed as an import, the protected root route (/) now redirects to /play instead of rendering ScenarioSelectionPage, and the protected /play-page route rendering PlayPage is removed entirely.

Router Navigation Updates

Layer / File(s) Summary
Redirect import, route change, and play-page removal
frontend/src/App.jsx
Redirect is added to react-router-dom imports; ScenarioSelectionPage import is removed; the / protected route is replaced with a <Redirect to="/play" />; the /play-page protected route rendering PlayPage is deleted.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

🐇 Hippity hop, the routes have changed,
No more selection page to be arranged!
The root now leaps to /play with glee,
And /play-page has been set free.
A redirect's hop — short, swift, and neat! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description addresses all required template sections with sufficient detail about the issue, solution, and risks, though the checklist items remain incomplete.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately describes the main change: redirecting the index route to the new play page, which aligns with the core modification in App.jsx.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch vps-72-get-rid-of-the-old-play-page

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@harbassan harbassan changed the title fix: added reidrect to the play page instead of the old page fix: redirect index to new play page Jun 16, 2026
@harbassan
harbassan merged commit 5688fb0 into master Jun 16, 2026
3 checks passed
@harbassan
harbassan deleted the vps-72-get-rid-of-the-old-play-page branch June 16, 2026 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants