chore(frontend): purge outdated files and code fragments#425
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughApp routing is restructured so ChangesRoute restructuring, context migration, and dead code removal
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
harbassan
force-pushed
the
chore/purge-codebase
branch
from
June 16, 2026 06:49
1d697fb to
8e7a4f8
Compare
harbassan
marked this pull request as ready for review
June 16, 2026 09:55
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/src/App.jsx`:
- Around line 117-135: The plain Route wrapper on line 117 allows
ScenarioContextProvider to mount and execute scenario queries before
authentication is verified by child ProtectedRoute components, creating an auth
boundary weakness. Replace the plain Route element wrapping the scenarioId path
with a ProtectedRoute element instead, keeping the same
path="/scenario/:scenarioId" and moving ScenarioContextProvider inside it. This
ensures authentication is checked before any scenario context initialization or
API calls occur, securing the route boundary.
- Line 128: The ProtectedRoute component at the specified location is using the
index prop, which is a React Router v6 feature, but since ProtectedRoute spreads
props to an underlying v5 Route component via ...rest, the index prop is not
recognized by v5 and will be ineffective. Replace the index prop with exact to
properly enforce exact path matching for the /scenario/:scenarioId route in
React Router v5.
In `@frontend/src/context/ScenarioContextProvider.jsx`:
- Line 44: Remove the debug console.log(scenarioId) statement from the
ScenarioContextProvider render path. This statement is executed on every render
and route transition, causing excessive log spam. Delete the entire console.log
line to clean up the debug output and improve the provider's performance
monitoring.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: da6adfac-acb2-46eb-8165-22ea9beb18be
⛔ Files ignored due to path filters (1)
frontend/src/features/login/backgroundImg.jpgis excluded by!**/*.jpg
📒 Files selected for processing (39)
frontend/src/App.jsxfrontend/src/components/ContextMenu.jsxfrontend/src/components/CreateScenarioCard/CreateScenarioCard.module.scssfrontend/src/components/DashedCard.jsxfrontend/src/components/DeleteButton.jsxfrontend/src/components/DeleteModal.jsxfrontend/src/components/GroupCard.jsxfrontend/src/components/ListContainer/ThumbnailList.jsxfrontend/src/components/ListContainer/ThumbnailList.module.scssfrontend/src/components/ListContainer/component.styles.jsfrontend/src/components/ShareModal/ShareModal.jsxfrontend/src/components/ShareModal/ShareModal.module.scssfrontend/src/components/SideBar/SideBar.jsxfrontend/src/components/SideBar/SideBar.module.scssfrontend/src/components/TopBar/TopBar.jsxfrontend/src/context/ScenarioContextProvider.jsxfrontend/src/context/SceneContextProvider.jsxfrontend/src/context/ToolbarContext.jsxfrontend/src/context/ToolbarContextProvider.jsxfrontend/src/features/authoring/components/BackModal/BackModal.jsxfrontend/src/features/authoring/components/BackModal/BackModal.module.scssfrontend/src/features/create/CreateLandingPage.cssfrontend/src/features/create/components/HorizontalGradientLine.cssfrontend/src/features/create/components/HorizontalGradientLine.jsxfrontend/src/features/groups/TopBar.jsxfrontend/src/features/login/LoginPage/GoogleIcon.jsxfrontend/src/features/login/LoginPage/LoginPage.module.scssfrontend/src/features/play/PlayPage.jsxfrontend/src/features/play/components/HorizontalGradientLine.cssfrontend/src/features/play/components/HorizontalGradientLine.jsxfrontend/src/features/play/playPage.cssfrontend/src/features/playScenario/components/HorizontalGradientLine.cssfrontend/src/features/playScenario/components/HorizontalGradientLine.jsxfrontend/src/features/playScenario/modals/ResetConfirmationModal.jsxfrontend/src/features/scenarioInfo/ScenarioInfo.jsxfrontend/src/features/scenarioInfo/components/GradientLine.jsxfrontend/src/features/scenarioSelection/ScenarioSelectionPage.jsxfrontend/src/features/sceneSelection/SceneSelectionPage.jsxfrontend/src/hooks/useScaledFontSize.jsx
💤 Files with no reviewable changes (36)
- frontend/src/features/create/components/HorizontalGradientLine.css
- frontend/src/features/scenarioInfo/components/GradientLine.jsx
- frontend/src/components/GroupCard.jsx
- frontend/src/features/login/LoginPage/GoogleIcon.jsx
- frontend/src/components/ListContainer/ThumbnailList.jsx
- frontend/src/features/authoring/components/BackModal/BackModal.module.scss
- frontend/src/features/play/PlayPage.jsx
- frontend/src/features/create/components/HorizontalGradientLine.jsx
- frontend/src/components/DeleteModal.jsx
- frontend/src/components/ListContainer/component.styles.js
- frontend/src/features/play/components/HorizontalGradientLine.jsx
- frontend/src/components/DashedCard.jsx
- frontend/src/features/playScenario/components/HorizontalGradientLine.css
- frontend/src/features/sceneSelection/SceneSelectionPage.jsx
- frontend/src/components/DeleteButton.jsx
- frontend/src/components/ShareModal/ShareModal.jsx
- frontend/src/components/ContextMenu.jsx
- frontend/src/components/SideBar/SideBar.module.scss
- frontend/src/hooks/useScaledFontSize.jsx
- frontend/src/context/ToolbarContext.jsx
- frontend/src/features/playScenario/components/HorizontalGradientLine.jsx
- frontend/src/features/playScenario/modals/ResetConfirmationModal.jsx
- frontend/src/features/play/components/HorizontalGradientLine.css
- frontend/src/features/create/CreateLandingPage.css
- frontend/src/context/ToolbarContextProvider.jsx
- frontend/src/features/authoring/components/BackModal/BackModal.jsx
- frontend/src/features/scenarioSelection/ScenarioSelectionPage.jsx
- frontend/src/features/play/playPage.css
- frontend/src/components/ShareModal/ShareModal.module.scss
- frontend/src/context/SceneContextProvider.jsx
- frontend/src/components/ListContainer/ThumbnailList.module.scss
- frontend/src/components/CreateScenarioCard/CreateScenarioCard.module.scss
- frontend/src/components/SideBar/SideBar.jsx
- frontend/src/components/TopBar/TopBar.jsx
- frontend/src/features/login/LoginPage/LoginPage.module.scss
- frontend/src/features/groups/TopBar.jsx
harbassan
force-pushed
the
chore/purge-codebase
branch
from
June 16, 2026 10:11
f8746e3 to
cce8603
Compare
leowla
approved these changes
Jun 16, 2026
Contributor
Author
Yep but that one seems generic enough as a hook to where I can see that being used in the future. |
This was referenced Jun 22, 2026
This was referenced Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The codebase is full of outdated files, which are components, contexts, style files or helpers. The scenario context also had some code only for compatibility reasons, which is no longer needed given that those parts of the codebase no longer exist due to previous changes.
Solution
Purge.
Risk
The risk lies in the ScenarioContext only, since that is where modifications were made regarding the compat changes. The rest are just deletions of files that are not used anywhere else, so completely safe.
Checklist
Summary by CodeRabbit
Refactor
Bug Fixes