Skip to content

REQ 034

sergio velderrain edited this page Nov 9, 2026 · 1 revision

REQ-034: Windows LUnit execution: pinned-commit suite, GitHub-hosted runner, SHA-256-verified packages, no VIPM, one named/lapsing waiver only (ADR-0003 Phase 1)

Requirement

Windows LUnit execution shall run a specific, pinned ni/labview-icon-editor commit's LUnit suite, unattended, inside a fresh GitHub-hosted-runner Windows LabVIEW container, with no VIPM installation, activation, or secret present anywhere in the container's build or runtime.

Rationale

Per ADR-0003: ni/labview-icon-editor#575 is a reference design to adapt (open/unmerged, not yet green end-to-end), not proof this engine's own implementation already works -- Phase 1 requires a real green run in this engine's own CI. GitHub-hosted runners are #575's own reference choice and avoid reintroducing the self-hosted long-lived-infrastructure risk this session's VBoxSVC finding demonstrated; this is a hosting-risk argument, not a claim the mechanism is already proven (round-2 review correction).

Fit Criterion

A fresh container build from this engine's pinned-by-digest nationalinstruments/labview Windows image, given SHA-256-verified LUnit/LUnit CLI VI package files, runs the pinned-commit suite unattended and produces a lunit.xml JUnit report covering every test case in that pinned suite, with zero failures and zero errors, with the single, narrow exception of the upstream-known Test Write Read Library Icon Data.vi tag-mismatch waiver if still unresolved upstream at implementation time (re-approved at every suite-pin update or it lapses; no other test's failure may be waived without a new ADR) -- and with no VIPM installation, activation call, secret, or credential present anywhere in the container's build or runtime. Implementation-level detail (exact CLI invocation, port, package versions) belongs in #87's design notes, not this statement.

Verification

Verified (live, fork + upstream): implemented and live-dispatch-proven via real workflow_dispatch runs on both the fork (#91, run 42368671863) and upstream VITechnologies/projectbuddy (run 42369960284) -- identical result: 10 total tests, 1 named waiver (Test Write Read Library Icon Data.vi), vipmPresence: false. Re-verified after #94's review fixed a missing-engineCommit/report-completeness/commit-validation gap shared with REQ-036 (#97): a fresh upstream run (42375129680) reproduces the same result, now also recording engineCommit. Tracked in #87.

Source

Software-Requirements-Specification

Priority

High

TestID

TEST-034

TestArtifact

Not yet implemented

CodeRef

Adapts ni/labview-icon-editor#575 (reference design only, not proof); implementation tracked in #87

Status

Planned

Clone this wiki locally