REQ 095

REQ-095: Show the reviewer the whole decision before the gate

Requirement

Before the gated job waits, a preflight job shall publish in the run summary the action class, the target, the content diff or its digest with an inspection link, the rationale, the expected effect, the rollback, the expiry, and the preflight check results.

Rationale

GitHub's review dialog shows only the run, so a reviewer must be able to decide from the run page alone. Run summaries in a public repository are public, including those of requests made for a private consumer, which run in a public engine repository with digest-only content (decision D6 in VITechnologies/projectbuddy#177).

Fit Criterion

Target-drift, leak-scan, and action-class policy checks run before the gate, and any failure ends the run before a reviewer is asked. In a public repository the summary contains no secret, credential, or private consumer identifier, shown with leak-scan fixtures.

Verification

Planned, TEST-097; not yet performed live. Offline fixture tests show the summary rows and inspection links, end a drifted or policy-violating request before the gate, and keep planted secrets, local paths, and private identifiers out of every published field, staged file, and decision record. Live verification waits for Phase 3 of VITechnologies/projectbuddy#179.

Source

Software-Requirements-Specification

Priority

High

TestID

TEST-097

TestArtifact

scripts/tests/test_approval_gate_checks.py and scripts/tests/test_approval_gate_record.py offline fixtures

CodeRef

scripts/approval_gate/preflight.py, scripts/approval_gate/leakscan.py, scripts/approval_gate/markdown.py, scripts/approval_gate/checks.py, .github/workflows/approval-gate.yml Preflight job

Status

Planned; offline fixture tests pass, no live proof yet