Fix fmt-style LogError/LogInfo calls to use proper printf-style format strings#847
Merged
Fix fmt-style LogError/LogInfo calls to use proper printf-style format strings#847
Conversation
…t strings Co-authored-by: xusheng6 <94503187+xusheng6@users.noreply.github.com>
|
|
|
|
Copilot
AI
changed the title
[WIP] Fix fmt style LogError/LogInfo
Fix fmt-style LogError/LogInfo calls to use proper printf-style format strings
Sep 23, 2025
xusheng6
pushed a commit
that referenced
this pull request
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LogError and LogInfo functions expect printf-style format strings (using
%s,%d, etc. placeholders) but were being called with fmt-style format strings (using{}placeholders) in several locations, causing the formatting to fail.This PR fixes 8 problematic calls across 2 files by wrapping the fmt-style strings with
fmt::format()and passing them to LogError/LogInfo via%s, following the existing pattern established incli/main.cpp:382.Changes made:
In
core/debuggercontroller.cpp:In
core/adapters/dbgengttdadapter.cpp:Before:
After:
All existing printf-style LogError/LogInfo calls remain unchanged. The fix ensures proper string formatting while maintaining the benefits of fmt-style formatting through the
fmt::format()wrapper.Fixes #846.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.