Vcert-java initial implementation

[pegerto]

No description provided.

[pegerto]

Hi @tr1ck3r

could you take a look at the current progress, we are progressing on the development, we can add any suggestion base on your input.

[mr-tron]

You can remove register. It`s deprecated function.

[mr-tron]

i don't know how and what type of regular expressions dialect do you use, but remember, that regexp should match full string. so for example regexp .*\.example\.com should doesn't match cn www.example.company

[pegerto]

Hello I see, in this case, the test is validating that the API requires its correct from a stub external service https://github.com/opencredo/vcert-java-1/blob/68f1d07aaf4fc61e613361f68fb43b5932712cea/src/test/resources/mappings/cloud.certificatepolicies.di.json#L40

[mr-tron]

I dont big specialist in java. I didt know what java pattern.matches which match whole string. In golang you need to add ^ and $ to your regexp for matching whole string.

[mr-tron]

Also please move hardcoded tokens and urls in tests to environment variables.

[pegerto]

You can remove register. It`s deprecated function.

Done

[mr-tron]

As I understand you just rewrite golang code to java. We are going to make some changes in the nearest future. May be you can just write better code from beginning and not copy our errors.

    certificate.Request has unused public attribute PublicKeyAlgorithm - should be removed (duplicated by KeyType)
    certificate.Request has public field CSR []byte what make misunderstoonding what can bein this field: pem or asn encoded csr. Should be replaced with private filed csr and few methods like SetCSR (may be with auto detect type), GetCSRasn1, GetCSRpem
    few methods accept empty interface as private key. should be replaced with crypto.Signer interface
    rewrite retrive function for cloud connector. should be getting certID by cn/thumbprint/pickupid -> getting certificate by certID via /v1/certificate/ {id}
    `func (cfg *Config) LoadFromFile() error` should be replaced with `func LoadConfigFromFile(path) (*Config, error)`
    SetBaseURL should be replaced with additional argument in NewConnector function //discuss

[pegerto]

Hello @M-Tron

I fully understand we discuss this in our proposal, it will be good to have a more fluent API and refactor sections on our code, unfortunately, we are time constrained, so we implement as match parity as possible for tracking.

We will try to implement part of the refactoring in this initial PR.

[pegerto]

Also please move hardcoded tokens and urls in tests to environment variables.

we have externalized acceptance test so it can be run by an integration environment and document the variables in the README file

[mr-tron]

Can you also add example of library usages like https://github.com/Venafi/vcert/blob/master/example/main.go with

1. enrolling certificate
2. retrieving certificate
3. renew
4. checking certificate request with zone policies (I think CN will be enough)

[pegerto]

@mr-tron an Example class has been added this PR, The recommendation is to create a different project for examples, or submodule the project if more examples are required.