Offer suppression quick fixes for errors - #58
Merged
Merged
Conversation
|
| Filename | Overview |
|---|---|
| crates/analysis/src/actions.rs | Removes the severity gate from suppression quick-fix dispatch while preserving de-duplication and the unknown-suppression exclusion. |
| crates/analysis/tests/spec/QuickfixSuppress.ini | Updates the fixture comment to match the new bad-bool suppression behavior. |
| crates/analysis/tests/spec/QuickfixSuppress.spec.toml | Changes the quick-fix expectation for bad-bool from no suppression offer to a suppression offer. |
| docs/diagnostics.md | Documents that suppressions apply to any diagnostic code while still recommending fixes for error-level issues. |
Reviews (1): Last reviewed commit: "Offer suppression quick fixes for errors" | Re-trigger Greptile
ViTeXFTW
marked this pull request as ready for review
July 18, 2026 14:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
zerosyntax-disablequick fix for error diagnostics as well as warnings and hintsunknown-suppressiontypo hintWhy
The shared quick-fix dispatcher explicitly filtered out
Severity::Error, so only some diagnostic types could add a file-level disable pragma. Removing that gate makes the existing shared suppression action available consistently.Impact
Users can suppress any error or warning code from the editor's quick-fix menu instead of editing the pragma manually.
Validation
cargo fmt --all -- --checkcargo testgit diff --check