Allow percentages without percent signs - #59
Merged
Conversation
|
| Filename | Overview |
|---|---|
| crates/analysis/src/diagnostics.rs | Updates percent validation to accept bare numeric percentages only when enabled and adds tests for strict and opt-in modes. |
| crates/server/src/backend.rs | Reads the initialization option and applies it to the analyzer before serving diagnostics. |
| editors/vscode/src/extension.ts | Passes the setting to the server and adds a quick fix, but the action is also offered for malformed percentage values it cannot fix. |
| editors/vscode/src/test/suite/smoke.test.ts | Extends the smoke test to verify the bad-percent diagnostic and quick-fix availability. |
Reviews (2): Last reviewed commit: "Merge dev into allow-bare-percentages" | Re-trigger Greptile
ViTeXFTW
marked this pull request as ready for review
July 18, 2026 14:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
analysis.allowPercentagesWithoutSignanalyzer/server settingbad-percentdiagnosticWhy
The game parser accepts percentage values without a trailing
%, while ZeroSyntax intentionally required the sign. This keeps the strict behavior by default but lets users opt into engine-compatible syntax.Validation
cargo testcargo test -p zerosyntax-analysis --test specnpm run compilenpm run compile:testThe Electron smoke runner did not reach extension tests because VS Code 1.129 rejected the runner's launch flags.