winemetal: validate render draw state before encoding#759
Open
moreaki wants to merge 1 commit into
Open
Conversation
Guard render draw commands before passing them to Metal. If pipeline creation failed or an indexed draw carries an invalid index buffer/range, skip the draw and report the condition instead of letting Objective-C Metal validation raise an exception from the encoder. Persist whether a render encoder has seen a valid pipeline state across command batches by attaching the state to the encoder object. Signed-off-by: Roberto Nibali <rnibali@gmail.com>
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
Bot
added
the
OCA Required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validate winemetal render draw state before encoding draw calls into Metal.
This patch keeps track of whether the render encoder currently has a valid pipeline state and skips draw commands when no valid PSO is active. It also validates indexed draw buffer presence, type, offset/count range, and indirect draw argument buffer bounds before calling into Metal.
The intent is to keep invalid guest or failed pipeline state from becoming an Objective-C Metal validation exception and VM process crash.
Validation
git diff --checkkmk VBoxDxMton macOS/Arm using LLVM 15.0.7.Closes #756.
Signed-off-by: Roberto Nibali rnibali@gmail.com