Skip to content

DXMT: forward D3D10 start instance location#761

Open
moreaki wants to merge 1 commit into
VirtualBox:mainfrom
moreaki:agent/dxmt-d3d10-start-instance-fix
Open

DXMT: forward D3D10 start instance location#761
moreaki wants to merge 1 commit into
VirtualBox:mainfrom
moreaki:agent/dxmt-d3d10-start-instance-fix

Conversation

@moreaki

@moreaki moreaki commented Jul 8, 2026

Copy link
Copy Markdown

Summary

Forward the D3D10 DrawIndexedInstanced start-instance argument to the underlying D3D11 context.

MTLD3D10Device::DrawIndexedInstanced currently passes StartIndexLocation as the final DrawIndexedInstanced argument. That final argument is the start-instance/base-instance value, so it should use the incoming StartInstanceLocation parameter instead.

Why

D3D10 indexed instanced draws with a non-zero StartInstanceLocation can currently use the start-index value as the base instance. That can make instance ID based shader inputs and per-instance vertex data selection incorrect.

Validation

Closes #760.

Signed-off-by: Roberto Nibali rnibali@gmail.com

Signed-off-by: Roberto Nibali <rnibali@gmail.com>
@oracle-contributor-agreement

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Required At least one contributor does not have an approved Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DXMT D3D10 DrawIndexedInstanced forwards StartIndexLocation as StartInstanceLocation

1 participant