Skip to content

Devops cleanup - #44

Merged
gwaybio merged 8 commits into
WayScience:mainfrom
gwaybio:zp-cleanup
Aug 5, 2026
Merged

Devops cleanup#44
gwaybio merged 8 commits into
WayScience:mainfrom
gwaybio:zp-cleanup

Conversation

@gwaybio

@gwaybio gwaybio commented Aug 5, 2026

Copy link
Copy Markdown
Member

I made several quality of life changes (e.g., one sentence per line, cleaning up docs) without adding functionality (erring on the side of subtraction [e.g., dropping just])

What kind of change(s) are included?

  • Documentation (changes docs or other related content)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • These changes pass all pre-commit checks.
  • I have added comments to my code to help provide understanding
  • I have added a test which covers the code changes found within this PR
  • I have deleted all non-relevant text in this pull request template.

📚 Documentation preview 📚: https://zedprofiler--44.org.readthedocs.build/en/44/

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@gwaybio
gwaybio requested a review from d33bs August 5, 2026 12:54
@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@3a9656f). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #44   +/-   ##
=======================================
  Coverage        ?   92.48%           
=======================================
  Files           ?       15           
  Lines           ?     1344           
  Branches        ?        0           
=======================================
  Hits            ?     1243           
  Misses          ?      101           
  Partials        ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gwaybio

gwaybio commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

One thing I didn't touch in this PR is the partial CLI functionality - we can probably skip this for now

Comment thread justfile

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a helpful DevEx file we might want to keep. If you don't think the justfile is helpful as a format, maybe we port to a Makefile or poethepoet configuration?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as it was, the justfile setup was incompletely documented - unclear how/when to use, especially in the context of uv. My thought in this PR was to err toward subtraction, and that you would introduce any specific devex/ops cleanly, in the future (with a bias toward making decisions that expedite processing)

Comment thread src/zedprofiler/image_utils/__init__.py Outdated
@@ -0,0 +1,9 @@
from .image_utils import (

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider making the import here absolute to the package rather than relative. Generally, this is a practice that makes the import order more explicit and harder to ignore/forget about.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! good point. I was matching conventions in this project, updated to absolute imports everywhere in e06341f

@gwaybio
gwaybio merged commit 0cc15e7 into WayScience:main Aug 5, 2026
12 checks passed
@gwaybio
gwaybio deleted the zp-cleanup branch August 5, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants