Auto-delete Datasets left empty by missing-file cleanup - #19
Merged
Conversation
delete_missing_imports removes OMERO Images whose source file disappeared (e.g. an upstream folder rename), but left the now-empty Dataset container behind. Track which datasets had images removed and, once cleanup for a run finishes, delete any that ended up with zero remaining images, pruning their dataset_state entries so they aren't recreated on the next scan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
delete_missing_importsremoves OMERO Images whose source file disappeared (e.g. an upstream folder rename), but previously left the now-empty Dataset container behind indefinitely.dataset_stateentry so it isn't recreated on the next scan.delete--waitbug this builds on.Test plan
uv run pytest tests/— 35/35 passinguv run pre-commit run --all-files— all hooks passingtest_delete_missing_imports_removes_now_empty_dataset) covers both the delete-when-empty case and a non-empty sibling dataset being left alone; caught two real bugs while writing this (an undefined-name typo and an unmocked live-call risk in the existing test), now fixed.Note: this does not retroactively clean up datasets that were already emptied via a manual bulk delete outside this code path (a one-time cleanup for those is being handled separately).