Regex java external flags - #1607
Merged
Merged
Conversation
jgaleotti
requested changes
Jun 23, 2026
jgaleotti
requested changes
Jun 24, 2026
jgaleotti
requested changes
Jun 25, 2026
jgaleotti
approved these changes
Jun 26, 2026
arcuri82
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for external flag usage in Java regex. In Java the
Pattern.compilemethod can take an integer representing the flag values, we can grab that value from the matcher in the Java client, pass it and use it to set the starting flag values for the visitor. This way we apply the external flags globally (unless overridden by flag embeddings).