fix: restrict forwarded IP trust - #4700
Merged
Merged
Conversation
The built-in nginx previously trusted X-Forwarded-For from every IPv4 and IPv6 peer whenever Weblate proxy handling was enabled. A client able to reach the container directly could therefore choose the address recorded by nginx and consumed by Weblate security controls. Require operators to identify trusted proxy addresses, resolve the chain in nginx so access logs retain the real client IP, and forward one normalized address to Weblate at offset zero. This preserves useful logging while preventing the application from reinterpreting an attacker-controlled chain.
Member
Author
|
Documentation companion in WeblateOrg/weblate#21168 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The built-in nginx previously trusted X-Forwarded-For from every IPv4 and IPv6 peer whenever Weblate proxy handling was enabled. A client able to reach the container directly could therefore choose the address recorded by nginx and consumed by Weblate security controls.
Require operators to identify trusted proxy addresses, resolve the chain in nginx so access logs retain the real client IP, and forward one normalized address to Weblate at offset zero. This preserves useful logging while preventing the application from reinterpreting an attacker-controlled chain.