Summary
SuggestionStore accepts positive max-age and max-count environment values without documented upper bounds.
Evidence
SuggestionStore.ResolveMaxAge parses MaxAgeDaysEnvironmentVariable as a positive int and immediately returns TimeSpan.FromDays(days). ResolveMaxCount accepts any positive int as the retained suggestion count.
Impact
An extreme max-age can throw during TimeSpan.FromDays, and an extreme max-count can prevent pruning from bounding the store size as intended.
Expected
Clamp or reject max-age and max-count values above documented limits, and fall back safely on invalid or overflowing values.
Summary
SuggestionStoreaccepts positive max-age and max-count environment values without documented upper bounds.Evidence
SuggestionStore.ResolveMaxAgeparsesMaxAgeDaysEnvironmentVariableas a positiveintand immediately returnsTimeSpan.FromDays(days).ResolveMaxCountaccepts any positiveintas the retained suggestion count.Impact
An extreme max-age can throw during
TimeSpan.FromDays, and an extreme max-count can prevent pruning from bounding the store size as intended.Expected
Clamp or reject max-age and max-count values above documented limits, and fall back safely on invalid or overflowing values.