Skip to content

Cap runtime environment override values - #2960

Merged
Widthdom merged 4 commits into
mainfrom
fix-issue2916-2915-2890-2889
Jun 3, 2026
Merged

Cap runtime environment override values#2960
Widthdom merged 4 commits into
mainfrom
fix-issue2916-2915-2890-2889

Conversation

@Widthdom

@Widthdom Widthdom commented Jun 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • Cap GitHub suggestion submission timeout overrides to 1-300 seconds.
  • Cap suggestion retention age/count overrides, including .cdidxrc.json validation.
  • Cap global log rotation size overrides from CLI and environment variables.
  • Cap SQLite cache/mmap performance environment overrides.

Validation

  • dotnet build -p:UseSharedCompilation=false
  • dotnet run --project tools/CodeIndex.Changelog -- check
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --no-build --filter FullyQualifiedName~GitHubIssueReporterTests -p:UseSharedCompilation=false
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --no-build --filter FullyQualifiedName~SuggestionStoreTests -p:UseSharedCompilation=false
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --no-build --filter FullyQualifiedName~CdidxConfigFileTests -p:UseSharedCompilation=false
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --no-build --filter FullyQualifiedName~GlobalToolLogTests -p:UseSharedCompilation=false
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --no-build --filter FullyQualifiedName~ProgramRunnerTests.Run_LogMaxSizeMbAboveMaximum_ReturnsInvalidArgument -p:UseSharedCompilation=false
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --no-build --filter FullyQualifiedName~DatabaseTests.Constructor_ -p:UseSharedCompilation=false
  • dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --json
  • Adversarial review: No blocking/actionable issues found.

Full-suite note: dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --no-build -p:UseSharedCompilation=false failed during validation with ReferenceExtractorTests.Extract_SQL_DeleteUsingMixedTableAndTempSourcesAfterComma_AreNotTreatedAsComments; the same test passed when filtered directly in both target frameworks. This order-dependent suite failure is already tracked by #2947.

Follow-up Issues

Fixes #2916
Fixes #2915
Fixes #2890
Fixes #2889

@Widthdom
Widthdom marked this pull request as ready for review June 2, 2026 21:41
@Widthdom
Widthdom force-pushed the fix-issue2916-2915-2890-2889 branch from 938d1c8 to a477039 Compare June 3, 2026 01:30
@Widthdom
Widthdom merged commit 2e2b204 into main Jun 3, 2026
11 checks passed
@Widthdom
Widthdom deleted the fix-issue2916-2915-2890-2889 branch June 3, 2026 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant