Summary
Remove the unused duplicate Git LFS pointer-size constant from FileIndexer, or move both consumers to a shared constant.
Current v1.38.0 evidence / reproduction
unused --actionable identifies FileIndexer.GitLfsPointerMaxBytes as the only actionable production candidate. The same-named constant in FileContentLoader is used, while the FileIndexer definition has no references beyond its declaration.
Impact
Duplicate policy constants can drift and create uncertainty about which limit is authoritative.
Suggested direction / acceptance criteria
- Delete the dead definition if it is obsolete, or centralize the LFS pointer threshold if both types should share it.
- Keep behavior unchanged and add/update a focused test only if the constant is centralized.
Dogfooding candidate IDs: R017. Verified against cdidx v1.38.0 at commit 2919bfc9b1b83cfa7ae1d964845d0f9ffca002d1.
Summary
Remove the unused duplicate Git LFS pointer-size constant from
FileIndexer, or move both consumers to a shared constant.Current v1.38.0 evidence / reproduction
unused --actionableidentifiesFileIndexer.GitLfsPointerMaxBytesas the only actionable production candidate. The same-named constant inFileContentLoaderis used, while theFileIndexerdefinition has no references beyond its declaration.Impact
Duplicate policy constants can drift and create uncertainty about which limit is authoritative.
Suggested direction / acceptance criteria
Dogfooding candidate IDs: R017. Verified against cdidx v1.38.0 at commit
2919bfc9b1b83cfa7ae1d964845d0f9ffca002d1.