Remove unused Git LFS pointer-size constant - #4662
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FileIndexer.GitLfsPointerMaxBytesconstant.FileContentLoaderas the sole owner and user of the unchanged Git LFS pointer-size threshold.Root cause
FileIndexerretained a private duplicate after Git LFS pointer detection was owned byFileContentLoader. The duplicate had no references and could drift from the active threshold.Impact
No runtime, CLI, or MCP behavior changes. The change removes ambiguity over which component owns the threshold.
Validation
dotnet build CodeIndex.sln -c Release --no-restore -p:UseSharedCompilation=falsedotnet build CodeIndex.sln -c Debug --no-restore -p:UseSharedCompilation=falsedotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release --no-build --no-restore -p:UseSharedCompilation=false -m:1 --filter FullyQualifiedName~GitLfs(net8.0: 4 passed; net9.0: 4 passed)dotnet run --project tools/CodeIndex.Changelog -- checkgit diff --check origin/main..HEADDocumentation and changelog
changelog.d/unreleased/4587.internal.mdwith English and Japanese entries.Follow-up candidates
Fixes #4587