Skip to content

Remove unused Git LFS pointer-size constant - #4662

Merged
Widthdom merged 1 commit into
mainfrom
fix-issue4587
Jul 18, 2026
Merged

Remove unused Git LFS pointer-size constant#4662
Widthdom merged 1 commit into
mainfrom
fix-issue4587

Conversation

@Widthdom

Copy link
Copy Markdown
Owner

Summary

  • Remove the unused duplicate FileIndexer.GitLfsPointerMaxBytes constant.
  • Keep FileContentLoader as the sole owner and user of the unchanged Git LFS pointer-size threshold.
  • Add a bilingual internal changelog fragment.

Root cause

FileIndexer retained a private duplicate after Git LFS pointer detection was owned by FileContentLoader. The duplicate had no references and could drift from the active threshold.

Impact

No runtime, CLI, or MCP behavior changes. The change removes ambiguity over which component owns the threshold.

Validation

  • dotnet build CodeIndex.sln -c Release --no-restore -p:UseSharedCompilation=false
  • dotnet build CodeIndex.sln -c Debug --no-restore -p:UseSharedCompilation=false
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release --no-build --no-restore -p:UseSharedCompilation=false -m:1 --filter FullyQualifiedName~GitLfs (net8.0: 4 passed; net9.0: 4 passed)
  • dotnet run --project tools/CodeIndex.Changelog -- check
  • git diff --check origin/main..HEAD
  • Local index rebuilt and verified fresh against HEAD
  • Codex adversarial review: No blocking/actionable issues found.

Documentation and changelog

  • Added changelog.d/unreleased/4587.internal.md with English and Japanese entries.
  • No user documentation changes were required because runtime, CLI, MCP, and indexing behavior are unchanged.

Follow-up candidates

  • None.

Fixes #4587

@Widthdom
Widthdom marked this pull request as ready for review July 18, 2026 00:43
@Widthdom
Widthdom merged commit 51beac3 into main Jul 18, 2026
8 checks passed
@Widthdom
Widthdom deleted the fix-issue4587 branch July 24, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove or centralize the unused FileIndexer.GitLfsPointerMaxBytes constant

1 participant