Fix trimmed backfill-fold JSON output - #1074
Merged
Merged
Conversation
Owner
Author
|
Work started on branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
backfill-foldJSON envelopes with source-generated DTOs so the trimmed release no longer aborts on--json.cdidx.dlland exercises both the success and missing-db JSON paths.Validation
dotnet builddotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter FullyQualifiedName~RunBackfillFold_PublishedTrimmedBinary_SerializesSuccessAndErrorJsondotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter FullyQualifiedName~RunBackfillFold_dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csprojDocumentation / Changelog
CHANGELOG.mdin both language sections.Fixes #181
Follow-up candidates
QueryCommandRunnerstill use anonymous-object serialization and may need the same source-generated treatment if trimmed-build JSON support is expanded beyondbackfill-fold.