Trim-safe QueryCommandRunner JSON outputs - #1103
Merged
Merged
Conversation
Owner
Author
|
Working on the follow-up candidates from this PR now. I’m starting from the latest |
Owner
Author
|
Follow-up candidates from this PR have been addressed in PR #1108. Implemented:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the follow-up candidates called out in PR #1074.
QueryCommandRunneranonymous JSON payloads with source-generated DTOs orJsonObjectbuilders.search,find, andvalidateJSON output.changelog.d/unreleased/1074.fixed.md.Validation
dotnet builddotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter FullyQualifiedName~RunPublishedTrimmedCli_SerializesQueryJsonAndErrorJsondotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter FullyQualifiedName~RunLanguages_JsonListsModernNodeModuleExtensionsdotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll index . --files src/CodeIndex/Cli/QueryCommandRunner.cs src/CodeIndex/Cli/JsonOutputContracts.cs tests/CodeIndex.Tests/QueryCommandRunnerTests.cs CHANGELOG.md --jsondotnet buildafter commitdotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll index . --commits HEAD --jsonafter commitDocumentation / Changelog
changelog.d/unreleased/1074.fixed.mdin both English and Japanese.CHANGELOG.mdentries so release prep can aggregate the fragment instead.Follow-up candidates
QueryCommandRunnerstill has other non-anonymous JSON output helpers that may need the same trim-safe treatment if trimmed-build JSON support is expanded further.