This repository was archived by the owner on Jun 7, 2023. It is now read-only.
MAIN-19695: Fix slideshow custom IDs#17576
Merged
mszabo-wikia merged 1 commit intoNov 15, 2019
Merged
Conversation
…e their tag attribute namesakes when preparing what to set for the slideshow's wrapper div
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Links
Description
This change ensures that
.wikia-slideshowgets the computed values forid(as well asdata-hashanddata-crop), instead of the (sanitized) tag attribute values set by the parser onmAttribsin the base class.This is because, for
Sanitizer::mergeAttributes, the second map overrides the first (bar special handling forclasses).Without this change, slideshow galleries for which editors specify custom IDs will not initialize properly, as
.wikia-slideshow's ID will be missing its expectedslideshow-prefix.Reviewers