Restrict access to users that have not accepted terms of use#507
Merged
jsnshrmn merged 4 commits intoAug 27, 2020
Merged
Conversation
jsnshrmn
requested changes
Aug 19, 2020
jsnshrmn
left a comment
Member
There was a problem hiding this comment.
I'd call TWLight.users.helpers.editor_data.editor_bundle_eligible() and update the editor's eligibility upon accepting terms. Other than that and one inline comment, this is looking good!
jsnshrmn
reviewed
Aug 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes in detail following the commit message guidelines
Added a condition to check if a user has agreed to the terms of service in order to get any access to the library's collections.
Rationale
The button for an individual partner is not greyed-out when a user has not accepted the terms of service, which shouldn't be happening.
Phabricator Ticket
T260229
How Has This Been Tested?
A test was added to check the correct functionality of the
user_update_eligibilitymanagement command and made manual tests to check that access is being granted or denied based on acceptance of the terms of use.Manual test instructions:
Manual test 1:
Access Collectionbutton should be greyed-out.Manual test 2:
Screenshots of your changes (if appropriate):
User is bundle eligible and has agreed to the terms of use
User is bundle eligible but has not agreed to the terms of use
User is bundle eligible, has not agreed to the terms of use, logged out and logged back in
Types of changes
What types of changes does your code introduce? Add an
xin all the boxes that apply: