Skip to content

Update blocktrans to blocktrans trimmed for homepage strings#617

Merged
jsnshrmn merged 1 commit into
WikipediaLibrary:masterfrom
Shubh1815:T275045
Feb 23, 2021
Merged

Update blocktrans to blocktrans trimmed for homepage strings#617
jsnshrmn merged 1 commit into
WikipediaLibrary:masterfrom
Shubh1815:T275045

Conversation

@Shubh1815

Copy link
Copy Markdown
Contributor

Description

Update blocktrans to blocktrans trimmed for homepage strings

Rationale

As per translation documentation, blocktrans-tagged strings should actually be blocktrans trimmed to remove whitespace for translators.

Phabricator Ticket

//: # T275045

How Has This Been Tested?

Screenshots of your changes (if appropriate):

Types of changes

What types of changes does your code introduce? Add an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@jsnshrmn jsnshrmn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@jsnshrmn
jsnshrmn merged commit 6544df6 into WikipediaLibrary:master Feb 23, 2021
@Shubh1815
Shubh1815 deleted the T275045 branch March 6, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants